Skip to content

Should support IDynamicObject in IEditorItem CanWrite #4998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Should support IDynamicObject in IEditorItem CanWrite #4998

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7f0607
Update IEditorItemExtensions.cs
handesoft Dec 30, 2024
bd8f306
Revert "Update IEditorItemExtensions.cs"
handesoft Dec 30, 2024
ed319b8
Should support IDynamicObject in IEditorItem CanWrite
handesoft Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BootstrapBlazor/Extensions/IEditorItemExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ private static bool IsVisible(this IEditorItem item, ItemChangedType changedType
/// <returns></returns>
public static bool CanWrite(this IEditorItem item, Type modelType)
{
return modelType == typeof(DynamicObject) || modelType.IsSubclassOf(typeof(DynamicObject)) || ComplexCanWrite();
return typeof(IDynamicObject).IsAssignableFrom(modelType) || ComplexCanWrite();

bool ComplexCanWrite()
{
Expand Down
Loading