feat(AutoFill): always filter the dropdown items by input text #5842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's Guide by SourceryThis pull request enhances the Sequence diagram for AutoComplete item clicksequenceDiagram
participant User
participant AutoComplete
User->>AutoComplete: Clicks on an item
AutoComplete->>AutoComplete: OnClickItem(val)
AutoComplete->>AutoComplete: TriggerFilter(val)
AutoComplete->>AutoComplete: OnBlurAsync(Value)
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
Overall Comments:
- The commit message could be improved to be more descriptive.
- Consider if the
TriggerFiltercalls should be awaited.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5842 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 660 660
Lines 30123 30125 +2
Branches 4255 4255
=========================================
+ Hits 30123 30125 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ArgoZhang
added a commit
that referenced
this pull request
Apr 17, 2025
* doc: 注释更新为英语 * refactor: 选择后更新下拉框 * refactor: 调整参数 * refactor: 移除代码
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #5841
Summary By Copilot
This pull request includes updates to enhance functionality in the
AutoCompleteandAutoFillcomponents, improve documentation in theSearchcomponent, and clean up unused code. The most important changes are grouped below by theme.Functional Enhancements:
TriggerFilterin theOnClickItemmethod forAutoCompleteto trigger filtering logic when an item is clicked. (src/BootstrapBlazor/Components/AutoComplete/AutoComplete.razor.cs, src/BootstrapBlazor/Components/AutoComplete/AutoComplete.razor.csR138-R139)TriggerFilterin theOnClickItemmethod forAutoFillto ensure the filter is triggered with the_displayTextvalue when an item is clicked. (src/BootstrapBlazor/Components/AutoFill/AutoFill.razor.cs, src/BootstrapBlazor/Components/AutoFill/AutoFill.razor.csR235-R236)Documentation Improvements:
Searchcomponent to improve clarity and consistency by translating them from Chinese to English. (src/BootstrapBlazor/Components/Search/Search.razor.cs, src/BootstrapBlazor/Components/Search/Search.razor.csL11-R146)Code Cleanup:
OnSearchClick,OnClearClick, and_filterItems. (src/BootstrapBlazor/Components/Search/Search.razor.cs, [1] [2] [3] [4]Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhance AutoComplete and AutoFill components by adding filtering logic when items are clicked, and improve documentation for the Search component
New Features:
Enhancements:
Chores: