feat(TabItem): add Id parameter #6124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's GuideThis PR adds an explicit Id parameter to TabItem by having it inherit from IdComponentBase, removes redundant ID-generation logic from the base class, and updates TabItemContent to consume the new Item.Id instead of generating IDs on the fly. Sequence Diagram: Updated ID Retrieval for TabItemContentsequenceDiagram
participant TIC as TabItemContent
participant TI as TabItem
TIC->>TI: Get Item.Id
note right of TIC: Accesses Id property directly from TabItem instance
TI-->>TIC: Return Id
Class Diagram: TabItem Inheritance and ID Handling ChangesclassDiagram
class IdComponentBase {
+Id: string?
#RetrieveId(): string?
%% -OnInitialized() method removed
}
class TabItem {
%% Inherits Id from IdComponentBase
%% Now extends IdComponentBase (previously ComponentBase)
}
class TabItemContent {
+Item: TabItem
%% -ComponentIdGenerator: IComponentIdGenerator removed
-BuildRenderTree(RenderTreeBuilder builder) // Uses Item.Id
}
IdComponentBase <|-- TabItem
TabItemContent o-- TabItem : Uses
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| builder.SetKey(_key); | ||
| builder.AddAttribute(5, "class", ClassString); | ||
| builder.AddAttribute(6, "id", ComponentIdGenerator.Generate(Item)); | ||
| builder.AddAttribute(6, "id", Item.Id); |
Contributor
There was a problem hiding this comment.
issue (bug_risk): Directly using Item.Id may produce a null id attribute
Consider using a helper like RetrieveId() or generating a fallback value to ensure the id attribute is always valid and unique when Item.Id is null.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6124 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 703 703
Lines 31059 31054 -5
Branches 4394 4393 -1
=========================================
- Hits 31059 31054 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6122
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enable explicit id assignment for TabItem by inheriting from IdComponentBase and update rendering to use the provided Id instead of auto-generating one
New Features:
Enhancements: