Skip to content

feat(TabItem): add Id parameter #6124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 1, 2025
Merged

feat(TabItem): add Id parameter #6124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
961107a
chore: bump version 9.7.1-beta02
ArgoZhang Jun 1, 2025
69579da
feat-tab
ArgoZhang Jun 1, 2025
c1080b8
Merge branch 'chore-tab-item' into refactor-tabitem
ArgoZhang Jun 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BootstrapBlazor/BootstrapBlazor.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk.Razor">

<PropertyGroup>
<Version>9.7.1-beta01</Version>
<Version>9.7.1-beta02</Version>
</PropertyGroup>

<ItemGroup>
Expand Down
10 changes: 0 additions & 10 deletions src/BootstrapBlazor/Components/BaseComponents/IdComponentBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,16 +29,6 @@ public abstract class IdComponentBase : BootstrapComponentBase
/// </summary>
protected virtual string? RetrieveId() => Id;

/// <summary>
/// <inheritdoc/>
/// </summary>
protected override void OnInitialized()
{
base.OnInitialized();

Id ??= ComponentIdGenerator.Generate(this);
}

/// <summary>
/// <inheritdoc/>
/// </summary>
Expand Down
2 changes: 1 addition & 1 deletion src/BootstrapBlazor/Components/Tab/TabItem.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ namespace BootstrapBlazor.Components;
/// <summary>
/// TabItem component
/// </summary>
public class TabItem : ComponentBase
public class TabItem : IdComponentBase
{
/// <summary>
/// Gets or sets the text. Default is null
Expand Down
9 changes: 1 addition & 8 deletions src/BootstrapBlazor/Components/Tab/TabItemContent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,6 @@ internal class TabItemContent : IComponent
[Parameter, NotNull]
public TabItem? Item { get; set; }

/// <summary>
/// Gets <see cref="IComponentIdGenerator"/> instrance
/// </summary>
[Inject]
[NotNull]
private IComponentIdGenerator? ComponentIdGenerator { get; set; }

private RenderHandle _renderHandle;

void IComponent.Attach(RenderHandle renderHandle)
Expand Down Expand Up @@ -49,7 +42,7 @@ private void BuildRenderTree(RenderTreeBuilder builder)
builder.OpenElement(0, "div");
builder.SetKey(_key);
builder.AddAttribute(5, "class", ClassString);
builder.AddAttribute(6, "id", ComponentIdGenerator.Generate(Item));
builder.AddAttribute(6, "id", Item.Id);
Copy link
Contributor

@sourcery-ai sourcery-ai bot Jun 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Directly using Item.Id may produce a null id attribute

Consider using a helper like RetrieveId() or generating a fallback value to ensure the id attribute is always valid and unique when Item.Id is null.

builder.AddContent(10, Item.ChildContent);
builder.CloseElement();
}
Expand Down