Skip to content

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jun 3, 2025

Link issues

fixes #6140

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Revert the change that made error logger flags nullable by restoring EnableErrorLogger and ShowToast as non-nullable booleans with default values, remove options-based fallback, and simplify rendering logic.

Bug Fixes:

  • Restore EnableErrorLogger and ShowToast as non-nullable bools with default true to prevent unintended null handling.

Enhancements:

  • Remove IOptionsMonitor injection and config-based initialization for error logger options.

@bb-auto bb-auto bot added the enhancement New feature or request label Jun 3, 2025
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jun 3, 2025

Reviewer's Guide

Reverts EnableErrorLogger and ShowToast from nullable booleans back to non-nullable with default true, removes the IOptionsMonitor-based fallback logic, and simplifies initialization and rendering conditions in the ErrorLogger component.

File-Level Changes

Change Details Files
Convert nullable configuration flags to non-nullable with defaults
  • Change EnableErrorLogger and ShowToast from bool? to bool
  • Assign default value = true to both parameters
  • Update XML docs to reflect new default behavior
src/BootstrapBlazor/Components/ErrorLogger/ErrorLogger.cs
src/BootstrapBlazor/Components/ErrorLogger/IErrorLogger.cs
Remove dependency on external options for default values
  • Delete IOptionsMonitor injection
  • Remove fallback assignments in OnInitialized for both flags
src/BootstrapBlazor/Components/ErrorLogger/ErrorLogger.cs
Simplify RenderContent logic for non-nullable flag
  • Update conditional from EnableErrorLogger ?? false to EnableErrorLogger
src/BootstrapBlazor/Components/ErrorLogger/ErrorLogger.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#6140 Revert the EnableErrorLogger property in IErrorLogger and ErrorLogger from nullable boolean (bool?) to non-nullable boolean (bool).
#6140 Revert the ShowToast property in IErrorLogger and ErrorLogger from nullable boolean (bool?) to non-nullable boolean (bool).

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the 9.7.0 milestone Jun 3, 2025
@ArgoZhang ArgoZhang merged commit 7336b9e into main Jun 3, 2025
2 of 3 checks passed
@ArgoZhang ArgoZhang deleted the revert-errorlogger branch June 3, 2025 09:29
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

revert(IErrorLogger): revert update bool to nullable bool

2 participants