Skip to content

revert(IErrorLogger): revert update bool to nullable bool #6141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025
Merged

revert(IErrorLogger): revert update bool to nullable bool #6141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions src/BootstrapBlazor/Components/ErrorLogger/ErrorLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,13 @@ public class ErrorLogger : ComponentBase, IErrorLogger
/// <inheritdoc/>
/// </summary>
[Parameter]
public bool? EnableErrorLogger { get; set; }
public bool EnableErrorLogger { get; set; } = true;

/// <summary>
/// <inheritdoc/>
/// </summary>
[Parameter]
public bool? ShowToast { get; set; }
public bool ShowToast { get; set; } = true;

/// <summary>
/// <inheritdoc/>
Expand Down Expand Up @@ -62,10 +62,6 @@ public class ErrorLogger : ComponentBase, IErrorLogger
[Parameter]
public Func<ErrorLogger, Task>? OnInitializedCallback { get; set; }

[Inject]
[NotNull]
private IOptionsMonitor<BootstrapBlazorOptions>? Options { get; set; }

[NotNull]
private BootstrapBlazorErrorBoundary? _errorBoundary = default;

Expand All @@ -77,8 +73,6 @@ protected override void OnInitialized()
base.OnInitialized();

ToastTitle ??= Localizer[nameof(ToastTitle)];
EnableErrorLogger ??= Options.CurrentValue.EnableErrorLogger;
ShowToast ??= Options.CurrentValue.ShowErrorLoggerToast;
}

/// <summary>
Expand Down Expand Up @@ -108,7 +102,7 @@ protected override void BuildRenderTree(RenderTreeBuilder builder)
builder.CloseComponent();
}

private RenderFragment? RenderContent => (EnableErrorLogger ?? false) ? RenderError : ChildContent;
private RenderFragment? RenderContent => EnableErrorLogger ? RenderError : ChildContent;

private RenderFragment RenderError => builder =>
{
Expand Down
8 changes: 4 additions & 4 deletions src/BootstrapBlazor/Components/ErrorLogger/IErrorLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@ namespace BootstrapBlazor.Components;
public interface IErrorLogger
{
/// <summary>
/// 获得/设置 是否开启全局异常捕获 默认 null 使用全局配置 <see cref="BootstrapBlazorOptions.EnableErrorLogger"/> 值
/// 获得/设置 是否开启全局异常捕获 默认 true
/// </summary>
bool? EnableErrorLogger { get; set; }
bool EnableErrorLogger { get; set; }

/// <summary>
/// 获得/设置 自定义 Error 处理方法 默认 null
Expand All @@ -23,9 +23,9 @@ public interface IErrorLogger
Task HandlerExceptionAsync(Exception ex);

/// <summary>
/// 获得 是否显示 Error 提示弹窗 默认 null 使用全局配置 <see cref="BootstrapBlazorOptions.ShowErrorLoggerToast"/> 值
/// 获得 是否显示 Error 提示弹窗 默认 true
/// </summary>
bool? ShowToast { get; }
bool ShowToast { get; }

/// <summary>
/// 获得 Error Toast 弹窗标题 默认读取资源文件内容
Expand Down
Loading