Skip to content

Conversation

@kimdiego2098
Copy link
Collaborator

@kimdiego2098 kimdiego2098 commented Oct 12, 2025

Issues

close #6888

Summary by Sourcery

Improve the performance of column visibility filtering by materializing the filtered items, optimizing lookups, and renaming the internal collection field.

Enhancements:

  • Rename the private VisibleColumns collection to a readonly _visibleColumns field for consistency
  • Materialize the filtered visible items list once in GetVisibleColumns to avoid repeated enumeration
  • Replace LINQ Any calls with List.Find checks to speed up column visibility lookups
  • Update initialization logic and UI templates to use the new _visibleColumns field

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 12, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Replaced repeated LINQ iterator allocations in visible-columns filtering by introducing a precomputed HashSet and refactoring GetVisibleColumns to use O(1) lookups.

Class diagram for updated Table component visible columns logic

classDiagram
    class Table {
        - List<ColumnVisibleItem> VisibleColumns
        - HashSet<string> VisibleColumnNames
        + IEnumerable<ITableColumn> GetVisibleColumns()
        + void InternalResetVisibleColumns(List<ITableColumn> columns, IEnumerable<string> names)
    }
    class ColumnVisibleItem {
        - string Name
        - bool Visible
    }
    class ITableColumn {
        + string GetFieldName()
        + bool GetIgnore()
        + int ShownWithBreakPoint
    }
    Table "1" *-- "*" ColumnVisibleItem : manages
    Table "1" *-- "*" ITableColumn : filters
    ColumnVisibleItem "*" --> "1" ITableColumn : matches by Name
Loading

Flow diagram for optimized visible columns filtering

flowchart TD
    A["VisibleColumns (List<ColumnVisibleItem>)"] --> B["VisibleColumnNames (HashSet<string>)"]
    B --> C["GetVisibleColumns()"]
    C --> D["Columns.Where(...) using VisibleColumnNames.Contains"]
Loading

File-Level Changes

Change Details Files
Introduce VisibleColumnNames hashset and refactor filtering logic
  • Add private VisibleColumnNames property
  • Populate the hashset in InternalResetVisibleColumns
  • Refactor GetVisibleColumns to use Contains and reorder predicates
src/BootstrapBlazor/Components/Table/Table.razor.Toolbar.cs
src/BootstrapBlazor/Components/Table/Table.razor.cs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto
Copy link

bb-auto bot commented Oct 12, 2025

Thanks for your PR, @kimdiego2098. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@bb-auto bb-auto bot requested a review from ArgoZhang October 12, 2025 12:38
sourcery-ai[bot]
sourcery-ai bot previously approved these changes Oct 12, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Oct 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (21238ea) to head (5ddbe23).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6886   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          739       739           
  Lines        31765     31765           
  Branches      4466      4466           
=========================================
  Hits         31765     31765           
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang changed the title feat(table): 减少linq迭代器对象的创建,避免Enumerable.Any处于嵌套循环中 feat(Table): improve performance for GetVisibleColumns function Oct 13, 2025
@bb-auto bb-auto bot added the enhancement New feature or request label Oct 13, 2025
@bb-auto bb-auto bot added this to the 9.11.0 milestone Oct 13, 2025
@ArgoZhang
Copy link
Member

@sourcery-ai summary

@ArgoZhang ArgoZhang merged commit 2f268c1 into main Oct 13, 2025
8 checks passed
@ArgoZhang ArgoZhang deleted the table_dev1 branch October 13, 2025 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Table): improve performance for GetVisibleColumns function

3 participants