Skip to content

feat(Table): improve performance for GetVisibleColumns function #6886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 13, 2025
+7 −7
Merged

feat(Table): improve performance for GetVisibleColumns function #6886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8b4818f
feat(table): 减少linq迭代器对象的创建,避免Enumerable.Any处于嵌套循环中
kimdiego2098 Oct 12, 2025
4fc264a
refactor: 重构代码
ArgoZhang Oct 13, 2025
cba3118
refactor: 重构代码
ArgoZhang Oct 13, 2025
5ddbe23
refactor: 移除变量
ArgoZhang Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BootstrapBlazor/Components/Table/Table.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
<span class="caret"></span>
</button>
<div class="dropdown-menu dropdown-menu-end shadow">
@foreach (var item in VisibleColumns)
@foreach (var item in _visibleColumns)
{
<div class="dropdown-item">
<Checkbox ShowAfterLabel="true" DisplayText="@item.DisplayName" IsDisabled="@GetColumnsListState(item)"
Expand Down
8 changes: 4 additions & 4 deletions src/BootstrapBlazor/Components/Table/Table.razor.Toolbar.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ public Func<TItem, bool>? ShowDeleteButtonCallback
/// <summary>
/// 获得/设置 各列是否显示状态集合
/// </summary>
private List<ColumnVisibleItem> VisibleColumns { get; } = [];
private readonly List<ColumnVisibleItem> _visibleColumns = [];

/// <summary>
/// 获得当前可见列集合
Expand All @@ -475,11 +475,11 @@ public Func<TItem, bool>? ShowDeleteButtonCallback
public IEnumerable<ITableColumn> GetVisibleColumns()
{
// 不可见列
var items = VisibleColumns.Where(i => i.Visible);
return Columns.Where(i => !i.GetIgnore() && items.Any(v => v.Name == i.GetFieldName()) && ScreenSize >= i.ShownWithBreakPoint);
var items = _visibleColumns.Where(i => i.Visible).ToList();
return Columns.Where(i => !i.GetIgnore() && items.Find(v => v.Name == i.GetFieldName()) != null && ScreenSize >= i.ShownWithBreakPoint);
}

private bool GetColumnsListState(ColumnVisibleItem item) => VisibleColumns.Find(i => i.Name == item.Name) is { Visible: true } && VisibleColumns.Where(i => i.Visible).DistinctBy(i => i.Name).Count(i => i.Visible) == 1;
private bool GetColumnsListState(ColumnVisibleItem item) => _visibleColumns.Find(i => i.Name == item.Name) is { Visible: true } && _visibleColumns.Where(i => i.Visible).DistinctBy(i => i.Name).Count(i => i.Visible) == 1;

private bool ShowAddForm { get; set; }

Expand Down
4 changes: 2 additions & 2 deletions src/BootstrapBlazor/Components/Table/Table.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1276,8 +1276,8 @@ private void InternalResetVisibleColumns(List<ITableColumn> columns, IEnumerable
}
}
}
VisibleColumns.Clear();
VisibleColumns.AddRange(cols);
_visibleColumns.Clear();
_visibleColumns.AddRange(cols);
}

/// <summary>
Expand Down
Loading