feat(Transfer): make search icon align right #6959

ArgoZhang · 2025-10-20T04:46:53Z

Link issues

fixes #6958

Summary By Copilot

Regression?

Yes
No

Risk

High
Medium
Low

Verification

Manual (required)
Automated

Packaging changes reviewed?

Yes
No
N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
Merge the latest code from the main branch

Summary by Sourcery

Adjust Transfer component styling to align the search icon to the right and use logical CSS padding properties.

Bug Fixes:

Align the search icon to the right side in the Transfer component search input.

Enhancements:

Replace physical padding-left/padding-right with logical padding-inline-start/padding-inline-end in the Transfer component.

sourcery-ai · 2025-10-20T04:46:59Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR refactors the Transfer component's SCSS to use logical CSS padding properties for better RTL support and shifts the search icon from the left to the right side by updating its positioning.

Class diagram for updated Transfer component SCSS structure

classDiagram
    class TransferSearchInput {
        +padding-inline-start: 10px
        +padding-inline-end: 30px
        +border-radius
        +border
        +color
    }
    class TransferSearchIcon {
        +width: 30px
        +position: absolute
        +right: 4px
        +top: 0
        +display: flex
        +align-items: center
    }
    TransferSearchInput <|-- TransferSearchIcon

File-Level Changes

Change	Details	Files
Use logical CSS padding properties	Replaced hardcoded padding-right with padding-inline-end Replaced hardcoded padding-left with padding-inline-start	`src/BootstrapBlazor/Components/Transfer/Transfer.razor.scss`
Align search icon to the right	Swapped the left positioning property for the search icon with a right property	`src/BootstrapBlazor/Components/Transfer/Transfer.razor.scss`

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#6958	Align the search icon to the right in the Transfer component.	✅

Possibly linked issues

feat(Transfer): make search icon align right #6958: The PR changes the search icon's position from left to right, directly addressing the issue's request.

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

Copilot

Pull Request Overview

Align the Transfer component’s search icon to the right and adjust input padding accordingly.

Move the search icon from left to right positioning
Replace physical paddings with logical padding-inline properties

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-10-20T04:47:28Z

src/BootstrapBlazor/Components/Transfer/Transfer.razor.scss

+    padding-inline-start: 10px;
+    padding-inline-end: 30px;


Mixing logical padding (padding-inline-*) with a physical position (right) breaks in RTL: inline-end maps to the left in RTL, but the icon is still physically pinned to the right, so the input text won’t have enough right padding and may overlap with the icon. Align the positioning with the padding by either using a logical inset (preferred) or switching back to physical padding on the right.

Copilot · 2025-10-20T04:47:28Z

src/BootstrapBlazor/Components/Transfer/Transfer.razor.scss

    transition: all .3s;
    position: absolute;
-    left: 4px;
+    right: 4px;


Mixing logical padding (padding-inline-*) with a physical position (right) breaks in RTL: inline-end maps to the left in RTL, but the icon is still physically pinned to the right, so the input text won’t have enough right padding and may overlap with the icon. Align the positioning with the padding by either using a logical inset (preferred) or switching back to physical padding on the right.

Suggested change

right: 4px;

inset-inline-end: 4px;

codecov · 2025-10-20T04:49:21Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4cff898) to head (32f68ff).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main     #6959   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          740       740           
  Lines        31896     31896           
  Branches      4473      4473           
=========================================
  Hits         31896     31896

Flag	Coverage Δ
BB	`100.00% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

feat(Transfer): make search icon align right

32f68ff

Copilot AI review requested due to automatic review settings October 20, 2025 04:46

bb-auto bot assigned ArgoZhang Oct 20, 2025

bb-auto bot added the enhancement New feature or request label Oct 20, 2025

bb-auto bot added this to the 9.11.0 milestone Oct 20, 2025

ArgoZhang merged commit 2de60c8 into main Oct 20, 2025
5 of 6 checks passed

ArgoZhang deleted the feat-trans branch October 20, 2025 04:47

sourcery-ai bot approved these changes Oct 20, 2025

View reviewed changes

Copilot AI reviewed Oct 20, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(Transfer): make search icon align right #6959

feat(Transfer): make search icon align right #6959

Uh oh!

ArgoZhang commented Oct 20, 2025 •

edited by sourcery-ai bot

Loading

Uh oh!

sourcery-ai bot commented Oct 20, 2025 •

edited

Loading

Reviewer's Guide

Class diagram for updated Transfer component SCSS structure

File-Level Changes

Assessment against linked issues

Possibly linked issues

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

Uh oh!

sourcery-ai bot left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Oct 20, 2025

Uh oh!

Copilot AI Oct 20, 2025

Uh oh!

codecov bot commented Oct 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

feat(Transfer): make search icon align right #6959

feat(Transfer): make search icon align right #6959

Uh oh!

Conversation

ArgoZhang commented Oct 20, 2025 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Link issues

Summary By Copilot

Regression?

Risk

Verification

Packaging changes reviewed?

☑️ Self Check before Merge

Summary by Sourcery

Uh oh!

sourcery-ai bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

Class diagram for updated Transfer component SCSS structure

File-Level Changes

Assessment against linked issues

Possibly linked issues

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Oct 20, 2025

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ArgoZhang commented Oct 20, 2025 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Oct 20, 2025 •

edited

Loading