-
-
Notifications
You must be signed in to change notification settings - Fork 362
feat(Transfer): make search icon align right #6959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -96,8 +96,8 @@ | |||||
| width: 100%; | ||||||
| display: inline-block; | ||||||
| border-radius: var(--bs-border-radius); | ||||||
| padding-right: 10px; | ||||||
| padding-left: 30px; | ||||||
| padding-inline-start: 10px; | ||||||
| padding-inline-end: 30px; | ||||||
| border: 1px solid var(--bs-border-color); | ||||||
| transition: border-color .2s cubic-bezier(.645,.045,.355,1); | ||||||
| color: #606266; | ||||||
|
|
@@ -112,7 +112,7 @@ | |||||
| width: 30px; | ||||||
| transition: all .3s; | ||||||
| position: absolute; | ||||||
| left: 4px; | ||||||
| right: 4px; | ||||||
|
||||||
| right: 4px; | |
| inset-inline-end: 4px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixing logical padding (padding-inline-*) with a physical position (right) breaks in RTL: inline-end maps to the left in RTL, but the icon is still physically pinned to the right, so the input text won’t have enough right padding and may overlap with the icon. Align the positioning with the padding by either using a logical inset (preferred) or switching back to physical padding on the right.