Fix webform email handler configuration #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicksantamaria
commented
May 9, 2025
| * - Ensures valid values for from_mail, return_path, and sender_mail fields. | ||
| * - Preserves original from_mail in reply_to. | ||
| */ | ||
| function bay_platform_dependencies_update_10005(&$sandbox) { |
Contributor
Author
There was a problem hiding this comment.
This function is the meat and potatoes of this PR.
nicksantamaria
requested review from
GROwen,
RonaldRinaldy,
anthony-malkoun and
vincent-gao
GROwen
approved these changes
May 9, 2025
RonaldRinaldy
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently there are potentially dozens of webforms that are not correctly sending emails when submissions are created due to misconfigurations. This PR aims to fix up any broken webform handler configs using an update hook.
Changes
Adds an update hook which checks every webform email handler and does the following checks:
return_pathandsender_mailfrom_mailuses the site default, or an email explicitly in theSMTP_FROM_WHITELISTenvironment variable.from_mailwas set to something disallowed, it moved that value toreply_to.Added actions workflow for phpcs
I don't trust my current knowledge of drupal best practice code standards so added to help me implement correctly.
Fixed code style violations
Sorry this made the PR diff much noisier than it should be.
Related PRs