Removed broken tide_event webform email handler #635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…its sending to that dead default email address
nicksantamaria
commented
May 9, 2025
|
|
||
| // Check if this is an email handler with the specific to_mail address. | ||
| if (isset($configuration['settings']['to_mail']) && | ||
| $configuration['settings']['to_mail'] === '[email protected]') { |
Contributor
Author
There was a problem hiding this comment.
This is the key logic - if the webform is still configured to send an email to this address it should be removed.
vincent-gao
approved these changes
May 14, 2025
Contributor
vincent-gao
left a comment
vincent-gao
left a comment
There was a problem hiding this comment.
thanks @nicksantamaria . looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira
N/A
Problem/Motivation
Currently most (if not all) tide projects are reporting issues with the tide_event webform not sending emails properly.
This is because the webform is configured out-of-the-box with a FROM address for some type of CRM solution that was from the original implementation in 2019.
Fix
There is no way to know specifically where each SDP tenant would want this to go, so the fix is just to remove the webform email handler all together if the incorrect default value is still in place.
Related PRs
dpc-sdp/bay_platform_dependencies#29