feat(tiering): Basic metrics #6086
Merged
+441
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dranikpg
commented
Nov 20, 2025
| }, | ||
| "disableTextWrap": false, | ||
| "editorMode": "builder", | ||
| "expr": "rate(dragonfly_tiered_hits[$__rate_interval])", |
Contributor
Author
There was a problem hiding this comment.
Probably should be an irate
romange
reviewed
Nov 20, 2025
|
|
||
| // Tiered metrics | ||
| { | ||
| AppendMetricWithoutLabels("tiered_entries", "Tiered entries", total.tiered_entries, |
romange
reviewed
Nov 20, 2025
Collaborator
romange
left a comment
romange
left a comment
There was a problem hiding this comment.
What about cool memory? we have memory_by_class_bytes - can you add anything accountable that contributes to memory usage?
btw, while you are at it, can you please also add m.search_stats.used_memory to memory_by_class_bytes that we missed.
Contributor
Author
Shouldn't be anything, as even cold_storage_bytes is part of just object memory usage.
Added |
romange
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basicc prometheus metrics for tiering
