Skip to content

feat(tiering): Basic metrics #6086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 21, 2025
Merged

feat(tiering): Basic metrics #6086

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
897348f
feat(tiering): Basic metrics
dranikpg Nov 20, 2025
1ea7aeb
panels
dranikpg Nov 20, 2025
7ab2ba0
add search.used_memory
dranikpg Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions src/server/server_family.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1955,6 +1955,49 @@ void PrintPrometheusMetrics(uint64_t uptime, const Metrics& m, DflyCmd* dfly_cmd
m.shard_stats.defrag_attempt_total, COUNTER, &resp->body());
AppendMetricWithoutLabels("defrag_objects_moved", "Objects moved",
m.shard_stats.defrag_realloc_total, COUNTER, &resp->body());

// Tiered metrics
{
AppendMetricWithoutLabels("tiered_entries", "Tiered entries", total.tiered_entries,
Copy link
Collaborator

@romange romange Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice grouping.

MetricType::GAUGE, &resp->body());

// Bytes: used, allocated, capacity
AppendMetricHeader("tiered_bytes", "Tiered bytes", MetricType::GAUGE, &resp->body());
AppendMetricValue("tiered_bytes", total.tiered_used_bytes, {"type"}, {"used"}, &resp->body());
AppendMetricValue("tiered_bytes", m.tiered_stats.cold_storage_bytes, {"type"}, {"cold"},
&resp->body());
AppendMetricValue("tiered_bytes", m.tiered_stats.allocated_bytes, {"type"}, {"allocated"},
&resp->body());
AppendMetricValue("tiered_bytes", m.tiered_stats.capacity_bytes, {"type"}, {"capacity"},
&resp->body());

// Events: stash, fetch, upload, cancel
AppendMetricHeader("tiered_events", "Tiered events", MetricType::COUNTER, &resp->body());
AppendMetricValue("tiered_events", m.tiered_stats.total_stashes, {"type"}, {"stash"},
&resp->body());
AppendMetricValue("tiered_events", m.tiered_stats.total_fetches, {"type"}, {"fetch"},
&resp->body());
AppendMetricValue("tiered_events", m.tiered_stats.total_uploads, {"type"}, {"upload"},
&resp->body());
AppendMetricValue("tiered_events", m.tiered_stats.total_cancels, {"type"}, {"cancel"},
&resp->body());
AppendMetricValue("tiered_events", m.tiered_stats.total_deletes, {"type"}, {"delete"},
&resp->body());

// Hits: ram, cool, missed
AppendMetricHeader("tiered_hits", "Tiered hits", MetricType::COUNTER, &resp->body());
AppendMetricValue("tiered_hits", m.events.ram_hits, {"type"}, {"ram"}, &resp->body());
AppendMetricValue("tiered_hits", m.events.ram_cool_hits, {"type"}, {"cool"}, &resp->body());
AppendMetricValue("tiered_hits", m.events.ram_misses, {"type"}, {"disk"}, &resp->body());

// Potential problems due to overloading system
AppendMetricHeader("tiered_overload", "Potential problems due to overlaoding",
MetricType::COUNTER, &resp->body());
AppendMetricValue("tiered_overload", m.tiered_stats.total_clients_throttled, {"type"},
{"client throttling"}, &resp->body());
AppendMetricValue("tiered_overload", m.tiered_stats.total_stash_overflows, {"type"},
{"stash overflows"}, &resp->body());
}
}

void ServerFamily::ConfigureMetrics(util::HttpListenerBase* http_base) {
Expand Down
Loading
Loading