chore: fix pre-existing pre-commit failures

[jag426]

Summary

• ty: Removed 29 now-unused # type: ignore comments (updated BS4 type stubs no longer need them), fixed two real type errors in models.py and scraper.py
• yamllint: Added required second space before inline # vN pin comments across all 4 workflow files; broke a 151-char line in dependabot-auto-merge.yml into a $BODY variable

Test plan

• uv run pre-commit run --all-files passes all hooks
• uv run pytest — 141 passed, 3 skipped

🤖 Generated with Claude Code

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fc1cf866-143d-437e-bda1-fb0d6c13939d

📥 Commits

Reviewing files that changed from the base of the PR and between ae440cf and 75d312a.

📒 Files selected for processing (1)

• peakbagger/scraper.py

🚧 Files skipped from review as they are similar to previous changes (1)

• peakbagger/scraper.py

---

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes

  • Improved JSON parsing and error handling in data-fetching paths.

• Chores

  • Formatting-only updates to CI/CD workflows.
  • Removed type-ignore annotations and tightened type safety across the codebase.
  • Internal refactor of how nested data structures are constructed.

Walkthrough

Formatting and typing cleanup across CI workflows, examples, core scraper/models, and tests: removed several # type: ignore annotations, tightened local typing, minor refactors in trip_report construction, and a small workflow PR-body extraction change. No public API changes.

Changes

Cohort / File(s)	Summary
GitHub Workflows — Formatting \.github/workflows/ci.yml, \.github/workflows/codeql.yml, \.github/workflows/release.yml, \.github/workflows/scorecard.yml	Whitespace and inline-comment spacing adjustments on uses/step lines; no action/version/flow changes.
GitHub Workflows — PR body refactor \.github/workflows/dependabot-auto-merge.yml	Composes the major-update message into a shell variable and passes it to gh pr comment instead of an inline literal; behavior unchanged.
Examples — JSON parsing typing examples/batch_peaks.py, examples/export_csv.py	Removed type: ignore from JSON parsing returns; batch_peaks.py adds JSONDecodeError handling and returns None on parse failure.
Core — Typing cleanup peakbagger/scraper.py, tests/test_statistics.py	Removed several # type: ignore[...] annotations and tightened local casts (e.g., explicit str() for href). No parsing/control-flow changes.
Core — trip_report construction peakbagger/models.py	Refactored to_dict methods to build trip_report via a local dict[str, Any] and assign once after populating optional fields; semantics unchanged.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• fix: correctly detect has_gpx and has_trip_report in ascent detail #67: Modifies ascent trip-report/GPX extraction in peakbagger/scraper.py; touches similar code paths where typing and URL extraction were adjusted.
• feat: additional --verbose and --debug logging options #8: Changes in peakbagger/scraper.py (adds logging and a module logger); related to the same module where type-ignores were removed.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'chore: fix pre-existing pre-commit failures' directly describes the main purpose of the pull request—fixing pre-commit tool failures related to type checking and YAML linting.
Description check	✅ Passed	The description covers the main changes (type-ignore removals and type fixes, yamllint formatting) and test results, but the PR template checkbox for change type is not filled in.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[dreamiurg]

@jag426 I appreciate your contributions! Apologies for the late merge. I have not noticed the PRs on this repo for a while.

[codecov]

Codecov Report

❌ Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.14%. Comparing base (6e4f918) to head (ac97722).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
peakbagger/models.py	75.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main      #68   +/-   ##
=======================================
  Coverage   92.13%   92.14%           
=======================================
  Files           9        9           
  Lines        1119     1120    +1     
=======================================
+ Hits         1031     1032    +1     
  Misses         88       88           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.