Merged
Conversation
|
|
simonpannek
force-pushed
the
cloud-testing
branch
2 times, most recently
from
3390bed to
9252478
Compare
simonpannek
force-pushed
the
cloud-testing
branch
from
67f8a8b to
a7b71fd
Compare
simonpannek
requested review from
99Lys,
bcmeireles,
howareyouman and
valterfrancisco-dremio
howareyouman
previously approved these changes
May 23, 2025
howareyouman
left a comment
howareyouman
left a comment
There was a problem hiding this comment.
I'm ok with generalisation of the tests for DC.
The only concern is the custom header, which could live outside of this repository.
99Lys
reviewed
May 23, 2025
bcmeireles
previously approved these changes
May 26, 2025
valterfrancisco-dremio
previously approved these changes
May 26, 2025
simonpannek
dismissed stale reviews from valterfrancisco-dremio and bcmeireles
via
5ffd122
simonpannek
force-pushed
the
cloud-testing
branch
from
8ab4e0b to
c09f677
Compare
simonpannek
requested review from
99Lys,
bcmeireles,
howareyouman and
valterfrancisco-dremio
bcmeireles
approved these changes
May 26, 2025
howareyouman
approved these changes
May 26, 2025
valterfrancisco-dremio
approved these changes
May 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adjusting dbt tests to run against other environments (with the goal of us being able to run tests against Dremio DC).
Description
This PR makes the testing framework more flexible, mainly by removing some hard coded values.