Merged
Conversation
Contributor
|
Thanks for looking into this. Can you please perform a rebase to clean up the merge commits? |
Member
|
@KarolNi thanks! just needs testing to check that this results in no change in generated code (or at least only white-space change) |
Contributor
|
Confirmed that Empy 3.3.4 and Empy 4.2 both generate identical outputs after this PR. So there is no impact for users on either the old or the new version. |
The 4.x branch expects a locals dictionary whereas 3.x expects keyword arguments, though it can use a locals dictionary too. Allegedly on 4.x we should be using the `locals` keyword argument instead of a positiional argument for maximum future-proofing, but that is incompatible with 3.x. If it breaks in the future, hopefully 3.x will be long gone so that argument can be used. Co-authored-by: Thomas Watson <twatson52@icloud.com>
This is no longer accepted by 4.x. `)` works with both 3.x and 4.x. Co-authored-by: Thomas Watson <twatson52@icloud.com>
No longer necessary now that we are 3.x and 4.x compatible. Co-authored-by: Thomas Watson <twatson52@icloud.com>
To streamline install and automated builds Also ignore test output
tpwrules
approved these changes
Jul 12, 2025
Contributor
tpwrules
left a comment
tpwrules
left a comment
There was a problem hiding this comment.
Smoothed out the commits and re-confirmed that empy 3.3.4 and 4.2 generate bit-identical code and binaries on ArduPilot.
This was referenced Jul 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated empy to recent version because of my CI failnig
#18