Open
Conversation
john-bodley
reviewed
Jun 17, 2020
| "upper": args["upper"], | ||
| "upperStrict": args["upperStrict"], | ||
| "alphaNumeric": args["alphaNumeric"], | ||
| "lower": args.get("lower"), |
Contributor
There was a problem hiding this comment.
Does lower and upper work with None? Per the bound filter documentation it seems these are both optional however there is no default specified.
I think it would be prudent to check if a value of None is equivalent to not providing the key.
Author
There was a problem hiding this comment.
I checked this, and it does not seem to be a problem, and they are equivalent.
Even in the Band class, Previously considered equal. HERE
Contributor
|
@armanaxh I'm not that well versed with the native Druid REST API (I'm more familiar with Druid SQL) and thus I don't really have a strong opinion with regards to which approach is best. Note it would good to add some unit tests to cover both the existence and non-existence of the fields. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #225