Skip to content

Fix bound filter property #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bound filter property #227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions pydruid/utils/filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,11 @@ def __init__(self, extraction_function=None, ordering="lexicographic", **args):
self.filter["filter"].update(
{
"dimension": args["dimension"],
"lower": args["lower"],
"lowerStrict": args["lowerStrict"],
"upper": args["upper"],
"upperStrict": args["upperStrict"],
"alphaNumeric": args["alphaNumeric"],
"lower": args.get("lower"),
Copy link
Contributor

@john-bodley john-bodley Jun 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does lower and upper work with None? Per the bound filter documentation it seems these are both optional however there is no default specified.

I think it would be prudent to check if a value of None is equivalent to not providing the key.

Copy link
Author

@armanaxh armanaxh Jun 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked this, and it does not seem to be a problem, and they are equivalent.

Even in the Band class, Previously considered equal. HERE

"lowerStrict": args.get("lowerStrict", False),
"upper": args.get("upper"),
"upperStrict": args.get("upperStrict", False),
"alphaNumeric": args.get("alphaNumeric", False),
"ordering": ordering,
}
)
Expand Down