Skip to content

Fix localization strings#2062

Merged
johlju merged 6 commits intodsccommunity:mainfrom
johlju:fix/hqrm-test-2
Mar 1, 2025
Merged

Fix localization strings#2062
johlju merged 6 commits intodsccommunity:mainfrom
johlju:fix/hqrm-test-2

Conversation

@johlju
Copy link
Member

@johlju johlju commented Feb 28, 2025

Pull Request (PR) description

  • SqlAudit
    • Fix localization strings in Assert method.
  • Save-SqlDscSqlServerMediaFile
    • Fix localizations strings that used wrong keys.

This Pull Request (PR) fixes the following issues

None. DUe to changes in DscResource.Test.

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju requested a review from a team as a code owner February 28, 2025 16:26
@codecov
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94%. Comparing base (85ea1ed) to head (23d7eb1).
Report is 12 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #2062   +/-   ##
====================================
  Coverage    94%     94%           
====================================
  Files        94      94           
  Lines      7930    7926    -4     
====================================
  Hits       7500    7500           
+ Misses      430     426    -4     
Flag Coverage Δ
unit 90% <100%> (-5%) ⬇️
Files with missing lines Coverage Δ
source/Classes/020.SqlAudit.ps1 100% <100%> (+<1%) ⬆️
...ces/DSC_SqlConfiguration/DSC_SqlConfiguration.psm1 100% <100%> (ø)
...urces/DSC_SqlDatabaseUser/DSC_SqlDatabaseUser.psm1 100% <100%> (ø)
...urce/DSCResources/DSC_SqlMaxDop/DSC_SqlMaxDop.psm1 100% <100%> (ø)
...urce/DSCResources/DSC_SqlMemory/DSC_SqlMemory.psm1 100% <100%> (ø)
...ce/DSCResources/DSC_SqlRSSetup/DSC_SqlRSSetup.psm1 100% <100%> (ø)
...sources/DSC_SqlReplication/DSC_SqlReplication.psm1 65% <100%> (ø)
...s/DSC_SqlServiceAccount/DSC_SqlServiceAccount.psm1 98% <100%> (ø)
source/Public/Save-SqlDscSqlServerMediaFile.ps1 84% <100%> (ø)

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 10 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit 666ef4e into dsccommunity:main Mar 1, 2025
44 checks passed
@johlju johlju deleted the fix/hqrm-test-2 branch March 1, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments