Fix quotedIdentifier and quotedString#290
Merged
jraymakers merged 3 commits intoduckdb:mainfrom Sep 16, 2025
Merged
Conversation
Collaborator
|
Whoops, thanks for noticing and for the fix (with tests!). |
Collaborator
|
I'm working on upgrading to DuckDB 1.4.0; my current plan for the next Node Neo release to be that upgrade. Let me know if you need this fix in a 1.3.x version. |
Contributor
Author
Thanks @jraymakers. No rush on my part. I have a local workaround so can happily wait for 1.4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered that the utility functions for quoting strings and identifiers only cover single instances of quotes. This PR adds tests and fixes the issue. Please let me know if you'd prefer any changes to this PR.