Update extension makefiles to support the latest sqllogictest.#295
Open
troycurtisjr wants to merge 1 commit intoduckdb:mainfrom
Open
Update extension makefiles to support the latest sqllogictest.#295troycurtisjr wants to merge 1 commit intoduckdb:mainfrom
troycurtisjr wants to merge 1 commit intoduckdb:mainfrom
Conversation
bb0fb91 to
bc0d1c5
Compare
troycurtisjr
commented
Dec 15, 2025
| endif | ||
|
|
||
| # Allow overriding the sqllogictest version in the event of incompatible changes | ||
| DUCKDB_SQLLOGICTEST_VERSION?=main |
Author
There was a problem hiding this comment.
Perhaps this should actually start off pinned to a specific hash to prevent future breakages?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While getting the tests working for the
inetextension, I noticed that thec_api_extensionsmakefiles was doing an unconstrained install of https://github.com/duckdb/duckdb-sqllogictest-python, and with a recentish update the calling method in these makefiles is broken. I do see that the version was later pinned in this repo, though that hasn't been updated in theinetextension yet, but in this MR I've updated things to use the latest sqllogictest.This PR does two things:
Note this currently this PR points to my outstanding branch for duckdb-sqllogictest, awaiting the merge of my PR there. I do think that PR is required here for two reasons:
require <extension>that doesn't work with out-of-tree extensions correctlyI've created this PR now for comments about the overall approach, and to understand if there is any additional testing to be done in this repo. I've currently tested my changes within the
inetextension, but it isn't clear to me how to best to further test the update.