Skip to content

Update extension makefiles to support the latest sqllogictest.#295

Open
troycurtisjr wants to merge 1 commit intoduckdb:mainfrom
troycurtisjr:sqllogictest-versioning
Open

Update extension makefiles to support the latest sqllogictest.#295
troycurtisjr wants to merge 1 commit intoduckdb:mainfrom
troycurtisjr:sqllogictest-versioning

Conversation

@troycurtisjr
Copy link

@troycurtisjr troycurtisjr commented Dec 15, 2025

While getting the tests working for the inet extension, I noticed that the c_api_extensions makefiles was doing an unconstrained install of https://github.com/duckdb/duckdb-sqllogictest-python, and with a recentish update the calling method in these makefiles is broken. I do see that the version was later pinned in this repo, though that hasn't been updated in the inet extension yet, but in this MR I've updated things to use the latest sqllogictest.

This PR does two things:

  • Adds in support for optionally locking to a "version" of duckdb-sqllogictest, which will be either a branch or hash, with a way for extensions to override it
  • Update the makefile to use the new calling conventions

Note this currently this PR points to my outstanding branch for duckdb-sqllogictest, awaiting the merge of my PR there. I do think that PR is required here for two reasons:

  • There is an undeclared pytest dependency now in duckdb-sqllogictest, needed to actually use the new calling conventions
  • There is a bug in handling require <extension> that doesn't work with out-of-tree extensions correctly

I've created this PR now for comments about the overall approach, and to understand if there is any additional testing to be done in this repo. I've currently tested my changes within the inet extension, but it isn't clear to me how to best to further test the update.

@troycurtisjr troycurtisjr force-pushed the sqllogictest-versioning branch from bb0fb91 to bc0d1c5 Compare December 15, 2025 00:50
endif

# Allow overriding the sqllogictest version in the event of incompatible changes
DUCKDB_SQLLOGICTEST_VERSION?=main
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should actually start off pinned to a specific hash to prevent future breakages?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant