-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add ability to parse a Takeout zip file and extract+import bookmarks #6820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to parse a Takeout zip file and extract+import bookmarks #6820
Conversation
29e253d
to
1b6e8bb
Compare
eda2570
to
1b8cac9
Compare
1b6e8bb
to
01d5515
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Posting review. Moving into testing. I will report after that.
...es/saved-sites-api/src/main/java/com/duckduckgo/savedsites/api/service/SavedSitesImporter.kt
Show resolved
Hide resolved
...java/com/duckduckgo/autofill/impl/importing/takeout/processor/TakeoutBookmarkImporterTest.kt
Show resolved
Hide resolved
...java/com/duckduckgo/autofill/impl/importing/takeout/processor/TakeoutBookmarkImporterTest.kt
Show resolved
Hide resolved
...pl/src/main/java/com/duckduckgo/autofill/impl/importing/takeout/zip/ZipEntryContentReader.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good with testing 👍
Approving, but would like to validate the proposed approach around reading the extracted file, or if this is something you already validated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't approve 😅
1b8cac9
to
59a1417
Compare
01d5515
to
1dfcbd0
Compare
6f10a11
to
1dfcbd0
Compare
1dfcbd0
to
0322886
Compare
Task/Issue URL: https://app.asana.com/1/137249556945/project/608920331025315/task/1211197010246723?focus=true
Description
Adds ability to parse a Google Takeout zip file containing exported bookmarks. This PR only adds underlying logic and dev settings to test it; prod UI isn't changed.
Steps to test this PR
Importing a valid file
internal
build typeAutofill Dev Settings
, and scroll toImport Bookmarks
dev settings 🆕Choose zip file (downloaded from Takeout)
and choose the Takeout zip; verify the bookmarks imported using theView Bookmarks
buttonImporting an invalid file
Choose zip file (downloaded from Takeout)
and choose a random other file (either not a Takeout zip or one that doesn't contain bookmarks) and verify it just reports it as invalid as a snackbarInstructions for generating a Takeout zip file
Tap
Launch Google Takeout (normal tab)
fromAutofill Dev Settings
and use this to generate a zip file for testing:- [ ] sign in
- [ ] Tap on
Deselect All
- [ ] Scroll down to
Chrome
, and check it- [ ] Optionally, Tap on
All Chrome data included
and choose only bookmarks- [ ] Scroll all the way down to the bottom and tap
Next step
- [ ] Leave all settings as is, and choose
Create export
- [ ] Wait a few seconds, then refresh the page until you see
Your latest export
shows the export you just created (at the top of the page)- [ ] Tap
Download
and confirm you want to save it