-
Notifications
You must be signed in to change notification settings - Fork 1.1k
UI for bookmarks import flow #6836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CDRussell
wants to merge
1
commit into
develop
Choose a base branch
from
feature/craig/streamline_import_bookmarks_webview_ui
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
UI for bookmarks import flow #6836
CDRussell
wants to merge
1
commit into
develop
from
feature/craig/streamline_import_bookmarks_webview_ui
+1,530
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 23, 2025
This was referenced Sep 23, 2025
a039a47
to
3f8950c
Compare
b3fac77
to
a14e381
Compare
77c3176
to
791ae21
Compare
1713a4f
to
cb2b5cb
Compare
4614087
to
9f3b412
Compare
cb2b5cb
to
bde236b
Compare
9f3b412
to
17a6c44
Compare
bde236b
to
dfbcd8e
Compare
17a6c44
to
e890ed7
Compare
7f7ff4b
to
2e9a36c
Compare
e890ed7
to
b217c11
Compare
2e9a36c
to
7ac6dca
Compare
0003be7
to
a714667
Compare
7ac6dca
to
49ab43d
Compare
a714667
to
a8e4b48
Compare
566d0e5
to
2575f8d
Compare
a8e4b48
to
8393d44
Compare
2575f8d
to
ad5d7bf
Compare
14c617a
to
39a6424
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 22 out of 23 changed files in this pull request and generated 6 comments.
Comments suppressed due to low confidence (1)
autofill/autofill-impl/src/main/res/values/donottranslate.xml:1
- Label 'Cancel' for the destructive action can be ambiguous alongside 'Continue'; consider changing it to 'Cancel Import' to make the consequence explicit.
<?xml version="1.0" encoding="utf-8"?><!--
...in/java/com/duckduckgo/autofill/impl/importing/takeout/webflow/ImportGoogleBookmarkResult.kt
Outdated
Show resolved
Hide resolved
...ntial/management/importbookmark/google/preimport/ImportFromGoogleBookmarksPreImportDialog.kt
Outdated
Show resolved
Hide resolved
...ntial/management/importbookmark/google/preimport/ImportFromGoogleBookmarksPreImportDialog.kt
Outdated
Show resolved
Hide resolved
...ntial/management/importbookmark/google/preimport/ImportFromGoogleBookmarksPreImportDialog.kt
Outdated
Show resolved
Hide resolved
...m/duckduckgo/autofill/impl/importing/takeout/webflow/ImportGoogleBookmarksWebFlowActivity.kt
Show resolved
Hide resolved
289bf6e
to
4d28998
Compare
f942c31
to
d2f84e9
Compare
204a3c4
to
94ccf12
Compare
94ccf12
to
889c892
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/608920331025315/task/1211407036705134?focus=true
Description
Adds UI to the bookmarks import flow, as well as a few more options in internal dev settings for testing them.
Autofill Dev Settings
screen (i.e., doesn't allow for flow to start in production)Steps to test this PR
Bookmark-import
internal
build typePre-import dialog
Autofill Dev Settings
, tap onLaunch Bookmarks import flow (with preimport dialog)
Import Now
and verify it launches the web flowWeb Flow, cancellations
Carrying on from the previous test
Cancel Import
Import Now
again, and this time use the back button, confirming you see the cancellation confirmation promptWeb flow, from a logged out state
You should not be logged in to a Google account already (which should be true if you're following these steps)
Web flow, from a signed in state
You should be logged in already to a Google account
WebView
, and instead jump straight to the in-progress flowWeb flow, dev-only peeking at the WebView