Initial support for pixel registry #6878
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladamski
force-pushed
the
la/pixel-schema
branch
from
e1030b3 to
700ea42
Compare
added 2 commits
October 6, 2025 21:12
This reverts commit 7e35fd0.
nshuba
reviewed
Oct 8, 2025
Comment on lines
+43
to
+64
| # Lint step for push (fail on error), for PRs run fix instead | ||
| - name: Check or Fix lint | ||
| id: lint | ||
| run: | | ||
| if [[ "${{ github.event_name }}" == "pull_request" ]]; then | ||
| npm run lint.fix || true | ||
| else | ||
| npm run lint | ||
| fi | ||
| working-directory: PixelDefinitions | ||
|
|
||
| # Commit and push changes if lint.fix was run and made changes | ||
| - name: Commit and push linter fixes (PRs only) | ||
| if: github.event_name == 'pull_request' | ||
| run: | | ||
| git config --global user.name "github-actions[bot]" | ||
| git config --global user.email "github-actions[bot]@users.noreply.github.com" | ||
| git add PixelDefinitions/ | ||
| if ! git diff --cached --quiet; then | ||
| git commit -m "chore: auto-fix lint errors" | ||
| git push | ||
| fi |
There was a problem hiding this comment.
Let's check with the Android team if they are ok with automated commits. Windows opted into this, but Apple preferred a simple diff output on error: https://app.asana.com/1/137249556945/project/414709148257752/task/1210957466937460?focus=true
| { | ||
| "epbf_android": { | ||
| "description": "User sent broken site report", | ||
| "owners": [], |
There was a problem hiding this comment.
I think this will fail validation with the latest schema release (owners should not be empty). Maybe Kate can be the owner for Android breakage pixels? Let's ask her in Asana.
added 2 commits
October 8, 2025 09:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1171671347221384/task/1210907475542624
Description
Initial support for https://app.asana.com/1/137249556945/project/1209805270658160/list/1209805324244987
Specific subtask for this PR: https://app.asana.com/1/137249556945/task/1210907475542626
Steps to test this PR
https://app.asana.com/1/137249556945/task/1209901985192016?focus=true using ".../Android/PixelDefinitions/" as the target directory where specified
Feature 1
UI changes