-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Initial support for pixel registry #6878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ladamski
wants to merge
11
commits into
develop
Choose a base branch
from
la/pixel-schema
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
64ecd0b
gitignore pixel cruft
a9c7f14
initial pixel schema WIP
4ad8c15
pixel_validation.yml
d6603fe
debug info for pixel validation
8831091
update GH token
7e35fd0
token test
700ea42
pixel nits
b60cb2b
revert flaky debug logs
3e34633
Revert "token test"
f48d5be
review fixes
59ad71b
lint
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
name: Pixel Schema Validation | ||
|
||
on: | ||
push: | ||
branches: [develop] | ||
pull_request: | ||
|
||
jobs: | ||
pixel-validation: | ||
runs-on: ubuntu-latest | ||
permissions: | ||
contents: write | ||
steps: | ||
- name: Checkout repository | ||
uses: actions/checkout@v4 | ||
with: | ||
token: ${{ secrets.DAXMOBILE_ANDROID_AUTOMATION }} | ||
ref: ${{ github.head_ref || github.ref }} | ||
|
||
- name: Use Node.js 20 | ||
uses: actions/setup-node@v4 | ||
with: | ||
node-version: 20.x | ||
|
||
- uses: actions/cache@v4 | ||
with: | ||
path: ~/.npm | ||
key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }} | ||
restore-keys: | | ||
${{ runner.os }}-node- | ||
|
||
- name: Checkout internal-github-asana-utils repo | ||
uses: actions/checkout@v4 | ||
with: | ||
token: ${{ secrets.DAXMOBILE_ANDROID_AUTOMATION }} | ||
path: internal-github-asana-utils | ||
repository: duckduckgo/internal-github-asana-utils | ||
|
||
- name: Install dependencies | ||
run: npm ci --verbose | ||
working-directory: PixelDefinitions | ||
|
||
# Lint step for push (fail on error), for PRs run fix instead | ||
- name: Check or Fix lint | ||
id: lint | ||
run: | | ||
if [[ "${{ github.event_name }}" == "pull_request" ]]; then | ||
npm run lint.fix || true | ||
else | ||
npm run lint | ||
fi | ||
working-directory: PixelDefinitions | ||
|
||
# Commit and push changes if lint.fix was run and made changes | ||
- name: Commit and push linter fixes (PRs only) | ||
if: github.event_name == 'pull_request' | ||
run: | | ||
git config --global user.name "github-actions[bot]" | ||
git config --global user.email "github-actions[bot]@users.noreply.github.com" | ||
git add PixelDefinitions/ | ||
if ! git diff --cached --quiet; then | ||
git commit -m "chore: auto-fix lint errors" | ||
git push | ||
fi | ||
Comment on lines
+40
to
+61
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's check with the Android team if they are ok with automated commits. Windows opted into this, but Apple preferred a simple diff output on error: https://app.asana.com/1/137249556945/project/414709148257752/task/1210957466937460?focus=true |
||
|
||
- name: Run pixel validation | ||
run: npm run validate-defs-without-formatting -- -g ../internal-github-asana-utils/user_map.yml | ||
working-directory: PixelDefinitions | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
*.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
For information about documenting pixels and validating them, see https://github.com/duckduckgo/pixel-schema/blob/main/README.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"assignee": "ladamski", | ||
"followers": ["jeannamatthews", "nshuba", "sammacbeth"], | ||
ladamski marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
"tagPixelOwners": false | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
{} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
// This file will define pixels sent by the native experiments framework | ||
"defaultSuffixes": [], | ||
ladamski marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
"activeExperiments": {} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.