Skip to content

Conversation

@jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Sep 24, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/72649045549333/task/1211453880963531?focus=true

Description

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Note

Adds Android legacy viewportWidthLegacy gate to trigger viewportWidthFix and makes the fix idempotent while simplifying reapply logic on preference merge.

  • WebCompat (Android):
    • Add viewportWidthLegacy setting in init() to invoke viewportWidthFix for legacy (non-adsjs) bundle.
  • Viewport width fix:
    • Make viewportWidthFix() idempotent via _viewportWidthFixApplied guard.
    • Simplify onUserPreferencesMerged() to always call viewportWidthFix() when viewportWidth is enabled.

Written by Cursor Bugbot for commit 6f98278. This will update automatically on new commits. Configure here.

@netlify
Copy link

netlify bot commented Sep 24, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 6f98278
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/68d7c3ff290cd700083b47a8
😎 Deploy Preview https://deploy-preview-1981--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Sep 24, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions
Copy link

github-actions bot commented Sep 24, 2025

[Beta] Generated file diff

Time updated: Sat, 27 Sep 2025 11:02:02 GMT

Android
    - android/adsjsContentScope.js
  • android/contentScope.js

File has changed

Apple
    - apple/contentScope.js

File has changed

Integration
    - integration/contentScope.js

File has changed

Windows
    - windows/contentScope.js

File has changed

@jonathanKingston jonathanKingston marked this pull request as ready for review September 24, 2025 14:31
@jonathanKingston jonathanKingston requested a review from a team as a code owner September 24, 2025 14:31
cursor[bot]

This comment was marked as outdated.

@jonathanKingston jonathanKingston added this pull request to the merge queue Sep 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 27, 2025
@jonathanKingston jonathanKingston added this pull request to the merge queue Sep 27, 2025
Merged via the queue into main with commit 9774c5a Sep 27, 2025
19 checks passed
@jonathanKingston jonathanKingston deleted the jkt/viewportFixLegacy branch September 27, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants