Skip to content

Add viewport width fix for legacy bundle #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 27, 2025
Merged

Add viewport width fix for legacy bundle #1981

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e1165b
Add viewport width fix for legacy bundle
jonathanKingston Sep 24, 2025
17c4ac9
Explain the change more and disable it by default
jonathanKingston Sep 24, 2025
6f98278
Merge branch 'main' into jkt/viewportFixLegacy
jonathanKingston Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions injected/src/features/web-compat.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,10 @@ export class WebCompat extends ContentFeature {
if (this.getFeatureSettingEnabled('enumerateDevices')) {
this.deviceEnumerationFix();
}
// Used by Android in the non adsjs version
if (this.getFeatureSettingEnabled('viewportWidthLegacy')) {
this.viewportWidthFix();
}
}

/**
Expand All @@ -151,10 +155,7 @@ export class WebCompat extends ContentFeature {
onUserPreferencesMerged(_updatedConfig) {
// Re-apply viewport width fix if viewport settings might have changed
if (this.getFeatureSettingEnabled('viewportWidth')) {
if (!this._viewportWidthFixApplied) {
this.viewportWidthFix();
this._viewportWidthFixApplied = true;
}
this.viewportWidthFix();
}
}

Expand Down Expand Up @@ -698,6 +699,10 @@ export class WebCompat extends ContentFeature {
}

viewportWidthFix() {
if (this._viewportWidthFixApplied) {
return;
}
this._viewportWidthFixApplied = true;
if (document.readyState === 'loading') {
// if the document is not ready, we may miss the original viewport tag
document.addEventListener('DOMContentLoaded', () => this.viewportWidthFixInner());
Expand Down
Loading