Skip to content
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,14 @@ export const variants = {
summary: t('nextSteps_pinAppToTaskbarWindows_summary'),
actionText: t('nextSteps_pinAppToTaskbarWindows_actionText'),
}),
/** @param {(translationId: keyof enStrings) => string} t */
subscription: (t) => ({
id: 'subscription',
icon: 'Subscription',
title: t('nextSteps_subscription_title'),
summary: t('nextSteps_subscription_summary'),
actionText: t('nextSteps_subscription_actionText'),
}),
};

export const otherText = {
Expand Down
12 changes: 12 additions & 0 deletions special-pages/pages/new-tab/app/next-steps/strings.json
Original file line number Diff line number Diff line change
Expand Up @@ -94,5 +94,17 @@
"nextSteps_pinAppToTaskbarWindows_confirmationText": {
"title": "Pinned to Taskbar!",
"note": "Button text after clicking on the Next Steps card for adding DDG app to OS dock"
},
"nextSteps_subscription_title": {
"title": "Unlock Your Free Trial",
"note": "Title of the Next Steps card for unlocking your free trial of DuckDuckGo subscription"
},
"nextSteps_subscription_summary": {
"title": "Try our subscription featuring a VPN + 3 more premium features.",
"note": "Summary of the Next Steps card about the DuckDuckGo subscription"
},
"nextSteps_subscription_actionText": {
"title": "Try Free for 7 Days",
"note": "Button text of the Next Steps card for trying the DuckDuckGo subscription"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Subscription Card Text Mismatch

The nextSteps_subscription_title, _summary, and _actionText strings for the subscription card differ between strings.json and new-tab.json. This inconsistency causes conflicting messaging for the UI.

Additional Locations (1)

Fix in Cursor Fix in Web

}
}
5 changes: 3 additions & 2 deletions special-pages/pages/new-tab/messages/types/next-steps.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@
"emailProtection",
"duckplayer",
"addAppToDockMac",
"pinAppToTaskbarWindows"
"pinAppToTaskbarWindows",
"subscription"
]
}
}
Expand All @@ -39,4 +40,4 @@
]
}
}
}
}
40 changes: 40 additions & 0 deletions special-pages/pages/new-tab/public/icons/Subscription-128.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 12 additions & 0 deletions special-pages/pages/new-tab/public/locales/en/new-tab.json
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,18 @@
"title": "Pinned to Taskbar!",
"note": "Button text after clicking on the Next Steps card for adding DDG app to OS dock"
},
"nextSteps_subscription_title": {
"title": "Unlock Premium Features Free for 7 Days!",
"note": "Title of the Next Steps card for subscribing to DuckDuckGo"
},
"nextSteps_subscription_summary": {
"title": "Right now, you can try our optional paid subscription featuring a VPN + 3 more premium features for free.",
"note": "Summary of the Next Steps card for subscribing to DuckDuckGo"
},
"nextSteps_subscription_actionText": {
"title": "Try It for Free",
"note": "Button text of the Next Steps card for subscribing to DuckDuckGo"
},
"favorites_show_less": {
"title": "Show less",
"note": "Button label to display fewer items"
Expand Down
30 changes: 22 additions & 8 deletions special-pages/pages/new-tab/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,28 @@
- **Example**: `?rmf-delay=10000`
- **Options**: Time in milliseconds

### Next Steps Cards
- **Purpose**: Displays the different Next Steps cards
- **Parameter**: `next-steps`
- **Example**: `?next-steps=bringStuff`
- **Options**:
- `bringStuff`
- `defaultApp`
- `blockCookies`
- `emailProtection`
- `duckplayer`
- `addAppToDockMac`
- `pinAppToTaskbarWindows`
- `subscription`

### Freemium PIR Banner
- **Purpose**: Tests different PIR banner states
- **Parameter**: `pir`
- **Example**: `?pir=onboarding`
- **Options**:
- `onboarding` - Shows onboarding PIR banner
- `scan_results` - Shows scan results PIR banner

## Privacy Protections widget

### Activity
Expand Down Expand Up @@ -170,15 +192,7 @@
- **Options**: Any positive integer


## Experiment Parameters

### Freemium PIR Banner
- **Purpose**: Tests different PIR banner states
- **Parameter**: `pir`
- **Example**: `?pir=onboarding`
- **Options**:
- `onboarding` - Shows onboarding PIR banner
- `scan_results` - Shows scan results PIR banner



Expand Down
3 changes: 2 additions & 1 deletion special-pages/pages/new-tab/types/new-tab.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,8 @@ export type NextStepsCardTypes =
| "emailProtection"
| "duckplayer"
| "addAppToDockMac"
| "pinAppToTaskbarWindows";
| "pinAppToTaskbarWindows"
| "subscription";
export type NextStepsCards = {
id: NextStepsCardTypes;
}[];
Expand Down
Loading