style: Updates position, orderes, trades and funding tabs #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruixhuang
reviewed
Oct 29, 2025
| cache[funding] = item | ||
|
|
||
| item.time = dydxFormatter.shared.interval(time: Date(milliseconds: funding.createdAtMilliseconds)) | ||
| item.time = Date(milliseconds: funding.createdAtMilliseconds) |
Collaborator
There was a problem hiding this comment.
Not a big deal, but in VIPER the data formatting is done at the presenter. But it's okay if you decided to relax the pattern.
Contributor
Author
There was a problem hiding this comment.
I think it makes sense to keep following the pattern so I'm going to move the data formatting to the presenter.
I think I do the same with the SharedFill so I'll update it there too
ruixhuang
previously approved these changes
Oct 29, 2025
ruixhuang
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2025-10-29.at.12.48.41.PM.mov