Skip to content

fix: stop updating compliance state #1946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tyleroooo wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: stop updating compliance state #1946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab1cfe0
stop-updating-compliance
tyleroooo Oct 16, 2025
08b12c0
Merge branch 'main' into tu/stop-updating-compliance
jaredvu Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
152 changes: 4 additions & 148 deletions src/bonsai/rest/compliance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,14 @@
import { ComplianceV2Response } from '@dydxprotocol/v4-client-js';

import { DydxChainId, DydxNetwork, ENVIRONMENT_CONFIG_MAP } from '@/constants/networks';
import { timeUnits } from '@/constants/time';

import { type AppDispatch, type RootState, type RootStore } from '@/state/_store';
import { type RootStore } from '@/state/_store';
import { getUserSourceWalletAddress, getUserWalletAddress } from '@/state/accountInfoSelectors';
import { appQueryClient } from '@/state/appQueryClient';
import { getSelectedDydxChainId, getSelectedNetwork } from '@/state/appSelectors';
import { createAppSelector } from '@/state/appTypes';
import {
ComplianceErrors,
setLocalAddressScreenV2Raw,
setSourceAddressScreenV2Raw,
} from '@/state/raw';
import { setLocalAddressScreenV2Raw, setSourceAddressScreenV2Raw } from '@/state/raw';
import { getHdKeyNonce } from '@/state/walletSelectors';

import { signCompliancePayload } from '@/lib/compliance';
import { mapIfPresent } from '@/lib/do';
import { removeTrailingSlash } from '@/lib/stringifyHelpers';

import { loadableIdle, loadableLoaded } from '../lib/loadable';
import { logBonsaiError } from '../logs';
import { selectRawLocalAddressScreenV2 } from '../selectors/base';
import { loadableIdle } from '../lib/loadable';
import { ComplianceResponse, ComplianceStatus } from '../types/summaryTypes';
import { IndexerWebsocketManager } from '../websocket/lib/indexerWebsocketManager';
import { createIndexerQueryStoreEffect } from './lib/indexerQueryStoreEffect';
import { queryResultToLoadable } from './lib/queryResultToLoadable';

Expand Down Expand Up @@ -78,85 +63,6 @@ export enum ComplianceAction {
INVALID_SURVEY = 'INVALID_SURVEY',
}

const COMPLIANCE_PAYLOAD_MESSAGE = 'Verify account ownership';

async function updateCompliance({
chainId,
address,
hdKeyNonce,
network,
status,
action,
}: {
chainId: DydxChainId;
address: string;
hdKeyNonce: number;
network: DydxNetwork;
status: ComplianceStatus;
action: ComplianceAction;
}) {
const networkConfig = ENVIRONMENT_CONFIG_MAP[network];
const indexerUrl = mapIfPresent(
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
networkConfig?.endpoints.indexers[0]?.api,
removeTrailingSlash
);
const payload = {
message: COMPLIANCE_PAYLOAD_MESSAGE,
action,
status,
chainId,
};

const signingResponse = await signCompliancePayload(address, hdKeyNonce, payload);
if (!signingResponse) {
return { status: ComplianceStatus.UNKNOWN };
}

const parsedSigningResponse = JSON.parse(signingResponse);
if (parsedSigningResponse.error != null) {
return { status: ComplianceStatus.UNKNOWN };
}

const { signedMessage, publicKey, timestamp, isKeplr } = parsedSigningResponse;

const urlAddition = isKeplr ? '/v4/compliance/geoblock-keplr' : '/v4/compliance/geoblock';
const hasMessageAndKey = signedMessage !== null && publicKey !== null;
const isKeplrOrHasTimestamp = timestamp !== null || isKeplr === true;

if (!hasMessageAndKey || !isKeplrOrHasTimestamp || !indexerUrl) {
return { status: ComplianceStatus.UNKNOWN };
}

const body = isKeplr
? {
address,
message: payload.message,
action: payload.action,
signedMessage,
pubkey: publicKey,
}
: {
address,
message: payload.message,
currentStatus: payload.status,
action: payload.action,
signedMessage,
pubkey: publicKey,
timestamp,
};

const options: RequestInit = {
method: 'POST',
headers: new globalThis.Headers([['Content-Type', 'application/json']]),
body: JSON.stringify(body),
};

const response = await fetch(`${indexerUrl}${urlAddition}`, options);
const data = await response.json();
return data as ComplianceV2Response & ComplianceErrors;
}

export function setUpIndexerLocalAddressScreenV2Query(store: RootStore) {
const cleanupEffect = createIndexerQueryStoreEffect(store, {
name: 'localAddressScreenV2',
Expand All @@ -167,7 +73,7 @@ export function setUpIndexerLocalAddressScreenV2Query(store: RootStore) {
address,
network,
],
getQueryFn: (indexerClient, { chainId, address, network, hdKeyNonce }) => {
getQueryFn: (indexerClient, { address, hdKeyNonce }) => {
if (address == null || hdKeyNonce == null) {
return null;
}
Expand All @@ -181,19 +87,8 @@ export function setUpIndexerLocalAddressScreenV2Query(store: RootStore) {
return { status: ComplianceStatus.UNKNOWN };
}

const updateResult = updateCompliance({
address,
hdKeyNonce,
chainId,
network,
status: firstScreenResult.status,
action: ComplianceAction.CONNECT,
});

return {
...firstScreenResult,
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
...(updateResult ?? {}),
};
};
},
Expand All @@ -208,42 +103,3 @@ export function setUpIndexerLocalAddressScreenV2Query(store: RootStore) {
store.dispatch(setLocalAddressScreenV2Raw(loadableIdle()));
};
}

export const triggerCompliance = (action: ComplianceAction) => {
return async (dispatch: AppDispatch, getState: () => RootState) => {
try {
const state = getState();
const currentLocalScreenStatus = selectRawLocalAddressScreenV2(state).data?.status;
const chainId = getSelectedDydxChainId(state);
const address = getUserWalletAddress(state);
const hdKeyNonce = getHdKeyNonce(state);
const network = getSelectedNetwork(state);

if (!address || !currentLocalScreenStatus || !hdKeyNonce) {
throw new Error('TriggerCompliance: No account connected or screen status not loaded');
}

const result = await updateCompliance({
chainId,
address,
hdKeyNonce,
network,
status: currentLocalScreenStatus,
action,
});

dispatch(setLocalAddressScreenV2Raw(loadableLoaded(result)));

// force refresh all account information from indexer
IndexerWebsocketManager.getActiveResources().forEach((r) => r.restart());
appQueryClient.invalidateQueries({
queryKey: ['indexer', 'account'],
});

return true;
} catch (e) {
logBonsaiError('TriggerCompliance', 'failed to update compliance', { error: e });
return false;
}
};
};
13 changes: 1 addition & 12 deletions src/components/ComplianceBanner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import styled from 'styled-components';

import { AlertType } from '@/constants/alerts';
import { ButtonSize, ButtonStyle, ButtonType } from '@/constants/buttons';
import { DialogTypes } from '@/constants/dialogs';
import { STRING_KEYS } from '@/constants/localization';
import { AppRoute, BASE_ROUTE } from '@/constants/routes';

Expand All @@ -17,9 +16,6 @@ import { useStringGetter } from '@/hooks/useStringGetter';

import breakpoints from '@/styles/breakpoints';

import { useAppDispatch } from '@/state/appTypes';
import { openDialog } from '@/state/dialogs';

import { AlertMessage } from './AlertMessage';
import { Button } from './Button';
import { IconName } from './Icon';
Expand All @@ -29,7 +25,6 @@ import { Link } from './Link';
export const ComplianceBanner = ({ className }: { className?: string }) => {
const [showLess, setShowLess] = useState(false);
const complianceBannerRef = useRef<HTMLDivElement>(null);
const dispatch = useAppDispatch();
const stringGetter = useStringGetter();
const { complianceMessage, complianceStatus, showComplianceBanner, showRestrictionWarning } =
useComplianceState();
Expand Down Expand Up @@ -69,13 +64,7 @@ export const ComplianceBanner = ({ className }: { className?: string }) => {

const action =
complianceStatus === ComplianceStatus.FIRST_STRIKE_CLOSE_ONLY ? (
<Button
tw="w-fit"
size={isTablet ? ButtonSize.XSmall : ButtonSize.Small}
onClick={() => {
dispatch(openDialog(DialogTypes.GeoCompliance()));
}}
>
<Button tw="w-fit" size={isTablet ? ButtonSize.XSmall : ButtonSize.Small} onClick={() => {}}>
{stringGetter({ key: STRING_KEYS.ACTION_REQUIRED })} →
</Button>
) : null;
Expand Down
2 changes: 0 additions & 2 deletions src/constants/dialogs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ export type ExternalLinkDialogProps = {
};
export type ExternalNavStrideDialogProps = {};
export type FillDetailsDialogProps = { fillId: string };
export type GeoComplianceDialogProps = {};
export type GlobalCommandDialogProps = {};
export type HelpDialogProps = {};
export type ExternalNavKeplrDialogProps = {};
Expand Down Expand Up @@ -144,7 +143,6 @@ export const DialogTypes = unionize(
ExternalNavKeplr: ofType<ExternalNavKeplrDialogProps>(),
ExternalNavStride: ofType<ExternalNavStrideDialogProps>(),
FillDetails: ofType<FillDetailsDialogProps>(),
GeoCompliance: ofType<GeoComplianceDialogProps>(),
GlobalCommand: ofType<GlobalCommandDialogProps>(),
Help: ofType<HelpDialogProps>(),
ManageAccount: ofType<ManageAccountDialogProps>(),
Expand Down
2 changes: 0 additions & 2 deletions src/layout/DialogManager.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import { ExchangeOfflineDialog } from '@/views/dialogs/ExchangeOfflineDialog';
import { ExternalLinkDialog } from '@/views/dialogs/ExternalLinkDialog';
import { ExternalNavKeplrDialog } from '@/views/dialogs/ExternalNavKeplrDialog';
import { ExternalNavStrideDialog } from '@/views/dialogs/ExternalNavStrideDialog';
import { GeoComplianceDialog } from '@/views/dialogs/GeoComplianceDialog';
import { GlobalCommandDialog } from '@/views/dialogs/GlobalCommandDialog';
import { HelpDialog } from '@/views/dialogs/HelpDialog';
import { ManageAccountDialog } from '@/views/dialogs/ManageAccountDialog/ManageAccountDialog';
Expand Down Expand Up @@ -115,7 +114,6 @@ export const DialogManager = React.memo(() => {
ExternalLink: (args) => <ExternalLinkDialog {...args} {...modalProps} />,
ExternalNavStride: (args) => <ExternalNavStrideDialog {...args} {...modalProps} />,
FillDetails: (args) => <FillDetailsDialog {...args} {...modalProps} />,
GeoCompliance: (args) => <GeoComplianceDialog {...args} {...modalProps} />,
GlobalCommand: (args) => <GlobalCommandDialog {...args} {...modalProps} />,
Help: (args) => <HelpDialog {...args} {...modalProps} />,
ExternalNavKeplr: (args) => <ExternalNavKeplrDialog {...args} {...modalProps} />,
Expand Down
Loading
Loading