fix: fire created_volume PostHog event before token generation#2283
fix: fire created_volume PostHog event before token generation#2283
Conversation
Move the PostHog event to immediately after tx.Commit succeeds, before generateVolumeContentToken. This ensures the event is always fired when a volume is created, even if token generation fails. Addresses review comment on #2282.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM — clean reorder that guarantees the analytics event fires on successful commit, regardless of downstream token generation failure.
Extended reasoning...
Overview
This PR modifies a single file (volume_create.go) by moving the created_volume PostHog event call from after generateVolumeContentToken to immediately after tx.Commit succeeds. No logic changes, no new code paths — pure reorder.
Security Risks
None. The change only affects analytics event ordering and does not touch auth, permissions, token generation logic, or any external-facing behavior.
Level of Scrutiny
Low. This is a mechanical reorder addressing a reviewer comment from #2282. The intent is clear and the implementation is correct: analytics should record that a volume was created when it is actually created (after commit), not contingent on a subsequent token generation step that can fail independently.
Other Factors
The inline bug comment flags a pre-existing issue (missing IdentifyAnalyticsTeam and GetPackageToPosthogProperties) that was introduced in #2282, not by this PR. This PR neither worsens nor fixes that gap — it is orthogonal to the reorder. That issue warrants a follow-up fix in a separate PR.
4 participants
Moves the
created_volumePostHog event to fire immediately aftertx.Commitsucceeds, beforegenerateVolumeContentToken. This ensures the analytics event is always recorded when a volume is created, even if token generation subsequently fails.Addresses review comment on #2282.