Skip to content

Add submit_io_batch changes. #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sanebay merged 1 commit into from
May 20, 2025
Merged

Add submit_io_batch changes. #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions conanfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class HomeBlocksConan(ConanFile):
name = "homeblocks"
version = "1.0.17"
version = "1.0.18"
homepage = "https://github.com/eBay/HomeBlocks"
description = "Block Store built on HomeStore"
topics = ("ebay")
Expand Down Expand Up @@ -43,7 +43,7 @@ def build_requirements(self):
self.test_requires("gtest/1.14.0")

def requirements(self):
self.requires("homestore/[~6.13]@oss/master", transitive_headers=True)
self.requires("homestore/[~6.14]@oss/master", transitive_headers=True)
self.requires("iomgr/[^11.3]@oss/master", transitive_headers=True)
self.requires("sisl/[^12.2]@oss/master", transitive_headers=True)
self.requires("lz4/1.9.4", override=True)
Expand Down
2 changes: 2 additions & 0 deletions src/lib/homeblks_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,8 @@ class HomeBlocksImpl : public HomeBlocks, public VolumeManager, public std::enab

NullAsyncResult unmap(const VolumePtr& vol, const vol_interface_req_ptr& req) final;

// Submit the io batch, which is a mandatory method to be called if read/write are issued
// with part_of_batchis set to true.
void submit_io_batch() final;

// see api comments in base class;
Expand Down
2 changes: 1 addition & 1 deletion src/lib/volume_mgr.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ VolumeManager::NullAsyncResult HomeBlocksImpl::unmap(const VolumePtr& vol, const
return folly::Unit();
}

void HomeBlocksImpl::submit_io_batch() { RELEASE_ASSERT(false, "submit_io_batch Not implemented"); }
void HomeBlocksImpl::submit_io_batch() { homestore::data_service().submit_io_batch(); }

void HomeBlocksImpl::on_write(int64_t lsn, const sisl::blob& header, const sisl::blob& key,
const std::vector< homestore::MultiBlkId >& new_blkids,
Expand Down
Loading