Skip to content

Add submit_io_batch changes.#97

Merged
sanebay merged 1 commit intoeBay:mainfrom
sanebay:submit_batch
May 20, 2025
Merged

Add submit_io_batch changes.#97
sanebay merged 1 commit intoeBay:mainfrom
sanebay:submit_batch

Conversation

@sanebay
Copy link
Contributor

@sanebay sanebay commented May 20, 2025

Submit the io batch, which is a mandatory method to be called if read/write are issued with part_of_batch is set to true. In those cases, without this method, IOs might not be even issued. No-op if previous io requests are not part of batch.

yamingk
yamingk previously approved these changes May 20, 2025
Submit the io batch, which is a mandatory method to be called if
read/write are issued with part_of_batch is set to true.
In those cases, without this method, IOs might not be even issued.
No-op if previous io requests are not part of batch.
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.74%. Comparing base (0b40663) to head (bfa03ba).
Report is 21 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/volume_mgr.cpp 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #97       +/-   ##
===========================================
+ Coverage   61.68%   80.74%   +19.05%     
===========================================
  Files          15       17        +2     
  Lines         462      883      +421     
  Branches       35       85       +50     
===========================================
+ Hits          285      713      +428     
+ Misses        158      126       -32     
- Partials       19       44       +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@raakella1 raakella1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@sanebay sanebay merged commit 6677415 into eBay:main May 20, 2025
19 checks passed
@sanebay sanebay deleted the submit_batch branch May 20, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants