Skip to content

[21592] Test generation of types with -python in ci#399

Merged
Mario-DL merged 1 commit intomasterfrom
ci/generate-python
Sep 18, 2024
Merged

[21592] Test generation of types with -python in ci#399
Mario-DL merged 1 commit intomasterfrom
ci/generate-python

Conversation

@Mario-DL
Copy link
Contributor

@Mario-DL Mario-DL commented Sep 16, 2024 •
edited by MiguelCompany
Loading

Description

This PR introduces a new step in CI that generates the types defined in dds-type-tests with -python arg for checking failures.

Susccessfull generation (after the fix in #294): here
Failing run (before the fix in the previous PR): here

Note: we may add backports

@Mergifyio backport 3.3.x 2.5.x 2.1.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL
Refs #21592: Run generation of types with -python in ci
4fd6eb2 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
@Mario-DL Mario-DL added this to the v4.0.2 milestone Sep 16, 2024
@MiguelCompany MiguelCompany self-requested a review September 17, 2024 10:00
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 17, 2024
@MiguelCompany
Copy link
Member

MiguelCompany commented Sep 17, 2024

@Mergifyio backport 3.3.x 2.5.x 2.1.x

@mergify
Copy link

mergify bot commented Sep 17, 2024 •
edited
Loading

backport 3.3.x 2.5.x 2.1.x

✅ Backports have been created

Details

@Mario-DL Mario-DL merged commit e605e07 into master Sep 18, 2024
@Mario-DL Mario-DL deleted the ci/generate-python branch September 18, 2024 06:06
mergify bot pushed a commit that referenced this pull request Sep 18, 2024
@Mario-DL @mergify
Run generation of types with -python in ci (#399)
f4315c1 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit e605e07)

# Conflicts:
#	.github/workflows/reusable-ubuntu-ci.yml
mergify bot pushed a commit that referenced this pull request Sep 18, 2024
@Mario-DL @mergify
Run generation of types with -python in ci (#399)
a689b51 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit e605e07)
This was referenced Sep 18, 2024
Merged
Closed
mergify bot pushed a commit that referenced this pull request Sep 18, 2024
@Mario-DL @mergify
Run generation of types with -python in ci (#399)
19bb714 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit e605e07)
@mergify mergify bot mentioned this pull request Sep 18, 2024
Closed
7 tasks
JesusPoderoso pushed a commit that referenced this pull request Sep 18, 2024
@Mario-DL @JesusPoderoso
Run generation of types with -python in ci (#399)
cafcdf0 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit e605e07)

# Conflicts:
#	.github/workflows/reusable-ubuntu-ci.yml
MiguelCompany pushed a commit that referenced this pull request Jan 17, 2025
@Mario-DL @MiguelCompany
Run generation of types with -python in ci (#399)
5430d5c 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit e605e07)
MiguelCompany pushed a commit that referenced this pull request Dec 10, 2025
@Mario-DL @MiguelCompany
Run generation of types with -python in ci (#399)
7ab063c 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit e605e07)
MiguelCompany pushed a commit that referenced this pull request Dec 19, 2025
@Mario-DL @MiguelCompany
Run generation of types with -python in ci (#399)
fe841f8 
Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit e605e07)

# Conflicts:
#	.github/workflows/reusable-ubuntu-ci.yml
emiliocuestaf added a commit that referenced this pull request Feb 6, 2026
@mergify @Mario-DL @emiliocuestaf
Test generation of types with -python in ci (backport #399) (#402)
e141597 
* Run generation of types with -python in ci (#399)

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
(cherry picked from commit e605e07)

# Conflicts:
#	.github/workflows/reusable-ubuntu-ci.yml

* Updating jdk version to work in Ubuntu 22

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>

* Downgrade dds-types-test commit

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>

* Try again with older commit

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>

* Addfailing tests to blacklist

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>

* Hardcode test removal

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>

* Add separate blacklist for python tests

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>

* WIP

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>

* Test to run only python with blacklist

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>

* Add common tests back

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>

---------

Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Co-authored-by: Mario Domínguez López <116071334+Mario-DL@users.noreply.github.com>
Co-authored-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees

No one assigned

Labels

ci-pending PR which CI is running

Projects

None yet

Milestone

v4.0.2

Development

Successfully merging this pull request may close these issues.

2 participants

@Mario-DL @MiguelCompany