Skip to content

[22849] Refactor builtin endpoints creation#5679

Closed
EugenioCollado wants to merge 4 commits intomasterfrom
22849/refactor_builtin_endpoints
Closed

[22849] Refactor builtin endpoints creation#5679
EugenioCollado wants to merge 4 commits intomasterfrom
22849/refactor_builtin_endpoints

Conversation

@EugenioCollado
Copy link
Copy Markdown
Contributor

@EugenioCollado EugenioCollado commented Mar 4, 2025

Description

Refactor of the creation of the PDP and EDP builtin endpoints in order to have a common method to create builtin endpoints.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
@EugenioCollado EugenioCollado added the ci-pending PR which CI is running label Mar 4, 2025
@EugenioCollado EugenioCollado added this to the v3.2.0 milestone Mar 4, 2025
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
@EugenioCollado EugenioCollado requested review from richiprosima and removed request for richiprosima March 4, 2025 13:44
@EugenioCollado EugenioCollado added ci-pending PR which CI is running and removed ci-pending PR which CI is running labels Mar 4, 2025
Signed-off-by: Eugenio Collado <eugeniocollado@eprosima.com>
@EugenioCollado EugenioCollado added ci-pending PR which CI is running and removed ci-pending PR which CI is running labels Mar 4, 2025
@EugenioCollado EugenioCollado requested review from richiprosima and removed request for richiprosima March 4, 2025 14:27
@EugenioCollado EugenioCollado mentioned this pull request Mar 4, 2025
22 tasks
@EugenioCollado EugenioCollado changed the title Refactor builtin endpoints creation [22849] Refactor builtin endpoints creation Mar 7, 2025
@MiguelCompany
Copy link
Copy Markdown
Member

Closing since changes are included in #5680.
We will manually backport this one to 3.1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-pending PR which CI is running

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants