[24057] Reset irrelevant sequence numbers interval in proxy readers by richiware · Pull Request #6241 · eProsima/Fast-DDS

richiware · 2026-01-08T11:22:04Z

Description

Reset irrelevant sequence numbers interval in proxy readers.

@Mergifyio backport 3.4.x 3.3.x 3.2.x 2.14.x

Contributor Checklist

Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are backport compatible: they do NOT break ABI nor change library core behavior.
Changes are API compatible.
N/A New feature has been added to the versions.md file (if applicable).
N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
If this is a critical bug fix, backports to the critical-only supported branches have been requested.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

test/blackbox/api/dds-pim/PubSubReader.hpp

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

test/blackbox/common/DDSBlackboxTestsContentFilter.cpp

mergify · 2026-01-08T18:36:21Z

🧪 CI Insights

Here's what we observed from your CI run for 693ecb6.

❌ Job Failures

Pipeline	Job	Health on `master`	Retries	🔍 CI Insights	📄 Logs
`Fast DDS MacOS CI`	`mac-ci / fastdds_test ()`		`0`	View	View
`Fast DDS Windows CI`	`windows-ci / fastdds_test (RelWithDebInfo, examples), v142`		`0`	View	View

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

MiguelCompany · 2026-01-15T10:55:05Z

@Mergifyio backport 3.4.x 3.3.x 2.14.x

mergify · 2026-01-15T10:55:20Z

backport 3.4.x 3.3.x 2.14.x

✅ Backports have been created

Details

#6256 [24057] Reset irrelevant sequence numbers interval in proxy readers (backport #6241) has been created for branch 3.4.x
#6257 [24057] Reset irrelevant sequence numbers interval in proxy readers (backport #6241) has been created for branch 3.3.x
#6258 [24057] Reset irrelevant sequence numbers interval in proxy readers (backport #6241) has been created for branch 2.14.x but encountered conflicts

MiguelCompany · 2026-01-15T10:55:39Z

Should be cherry-picked in #6197 after fixing conflicts

* Refs #24038. Regression test Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #24038. Fix Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #24038. Apply suggestion Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #24038. Apply new uncrustify Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> (cherry picked from commit 61f8677)

* Refs #24038. Regression test Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #24038. Fix Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #24038. Apply suggestion Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #24038. Apply new uncrustify Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> (cherry picked from commit 61f8677) # Conflicts: # test/blackbox/common/DDSBlackboxTestsContentFilter.cpp

* Refs #24038. Regression test Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #24038. Fix Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #24038. Apply suggestion Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #24038. Apply new uncrustify Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

* Refs #24038. Regression test Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #24038. Fix Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #24038. Apply suggestion Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #24038. Apply new uncrustify Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> (cherry picked from commit 61f8677) # Conflicts: # test/blackbox/common/DDSBlackboxTestsContentFilter.cpp

…6257) * Refs #24038. Regression test * Refs #24038. Fix * Refs #24038. Apply suggestion * Refs #24038. Apply new uncrustify --------- (cherry picked from commit 61f8677) Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Co-authored-by: Ricardo González <ricardo@richiware.dev>

…6258) * Reset irrelevant sequence numbers interval in proxy readers (#6241) * Refs #24038. Regression test Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #24038. Fix Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #24038. Apply suggestion Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #24038. Apply new uncrustify Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> (cherry picked from commit 61f8677) # Conflicts: # test/blackbox/common/DDSBlackboxTestsContentFilter.cpp * Fix reusing_reader_proxy test Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> --------- Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com> Co-authored-by: Ricardo González <ricardo@richiware.dev> Co-authored-by: Emilio Cuesta <emiliocuesta@eprosima.com>

* Refs #24038. Regression test Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #24038. Fix Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #24038. Apply suggestion Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #24038. Apply new uncrustify Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> (cherry picked from commit 61f8677)

…6256) * Refs #24038. Regression test * Refs #24038. Fix * Refs #24038. Apply suggestion * Refs #24038. Apply new uncrustify --------- (cherry picked from commit 61f8677) Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Co-authored-by: Ricardo González <ricardo@richiware.dev>

* Refs #24038. Regression test Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #24038. Fix Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #24038. Apply suggestion Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #24038. Apply new uncrustify Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

…DATA (#6181) (#6197) * Fix GAP messages are not sent when there is no Reader requesting the DATA (#6181) * Refs #23919. Tests Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Fix Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Fix cornercase Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Fix jobs needs log Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #23919. Apply suggestions Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> (cherry picked from commit 062258c) # Conflicts: # test/blackbox/common/DDSBlackboxTestsContentFilter.cpp * Reset irrelevant sequence numbers interval in proxy readers (#6241) * Refs #24038. Regression test Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #24038. Fix Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #24038. Apply suggestion Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> * Refs #24038. Apply new uncrustify Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> --------- Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev> Co-authored-by: Ricardo González <ricardo@richiware.dev>

Refs #24038. Regression test

83c7e16

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

richiware changed the title ~~Reset irrelevant sequence numbers interval in proxy readers~~ [24057] Reset irrelevant sequence numbers interval in proxy readers Jan 8, 2026

richiware added this to the v3.5.0 milestone Jan 8, 2026

MiguelCompany requested changes Jan 8, 2026

View reviewed changes

test/blackbox/api/dds-pim/PubSubReader.hpp Outdated Show resolved Hide resolved

Refs #24038. Fix

eaf896e

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

richiware force-pushed the bugfix/24038 branch from 42fd095 to eaf896e Compare January 8, 2026 11:36

richiware requested a review from MiguelCompany January 8, 2026 11:36

github-actions bot added the ci-pending PR which CI is running label Jan 8, 2026

MiguelCompany requested changes Jan 8, 2026

View reviewed changes

test/blackbox/common/DDSBlackboxTestsContentFilter.cpp Outdated Show resolved Hide resolved

Refs #24038. Apply suggestion

b9b4b7c

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

MiguelCompany previously approved these changes Jan 13, 2026

View reviewed changes

Refs #24038. Apply new uncrustify

693ecb6

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>

richiware dismissed MiguelCompany’s stale review via 693ecb6 January 14, 2026 08:01

richiware requested a review from MiguelCompany January 14, 2026 08:01

MiguelCompany approved these changes Jan 14, 2026

View reviewed changes

MiguelCompany merged commit 61f8677 into master Jan 15, 2026
26 of 28 checks passed

MiguelCompany deleted the bugfix/24038 branch January 15, 2026 10:52

mergify bot mentioned this pull request Jan 15, 2026

[24057] Reset irrelevant sequence numbers interval in proxy readers (backport #6241) #6256

Merged

12 tasks

mergify bot mentioned this pull request Jan 15, 2026

[24057] Reset irrelevant sequence numbers interval in proxy readers (backport #6241) #6257

Merged

12 tasks

mergify bot mentioned this pull request Jan 15, 2026

[24057] Reset irrelevant sequence numbers interval in proxy readers (backport #6241) #6258

Merged

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[24057] Reset irrelevant sequence numbers interval in proxy readers#6241

[24057] Reset irrelevant sequence numbers interval in proxy readers#6241
MiguelCompany merged 4 commits intomasterfrom
bugfix/24038

richiware commented Jan 8, 2026 •

edited by MiguelCompany

Loading

Uh oh!

Uh oh!

Uh oh!

mergify bot commented Jan 8, 2026 •

edited

Loading

Uh oh!

Uh oh!

MiguelCompany commented Jan 15, 2026

Uh oh!

mergify bot commented Jan 15, 2026 •

edited

Loading

Uh oh!

MiguelCompany commented Jan 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

richiware commented Jan 8, 2026 • edited by MiguelCompany Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contributor Checklist

Reviewer Checklist

Uh oh!

Uh oh!

Uh oh!

mergify bot commented Jan 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 CI Insights

❌ Job Failures

Uh oh!

Uh oh!

MiguelCompany commented Jan 15, 2026

Uh oh!

mergify bot commented Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

MiguelCompany commented Jan 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

richiware commented Jan 8, 2026 •

edited by MiguelCompany

Loading

mergify bot commented Jan 8, 2026 •

edited

Loading

mergify bot commented Jan 15, 2026 •

edited

Loading