Skip to content

Conversation

mathias-goebel
Copy link
Contributor

@mathias-goebel mathias-goebel commented Oct 25, 2018

Closes #2239
by using variables present in the env the script supports unattended installation

by using variables present in the env the script supports unattended installation
@duncdrum duncdrum requested a review from a team October 25, 2018 13:19
@dizzzz dizzzz requested review from adamretter and ljo October 25, 2018 16:26
@dizzzz dizzzz added enhancement new features, suggestions, etc. needs documentation Signals issues or PRs that will require an update to the documentation repo needs 4.x.x backport needs 5.x.x backport labels Oct 25, 2018
@duncdrum
Copy link
Contributor

duncdrum commented Oct 25, 2018

@dizzzz indeed it does.
@mathias-goebel from what i can tell the code listings https://exist-db.org/exist/apps/doc/advanced-installation need to be updated with these changes.
You can find the associated files in our documentation repo

@mathias-goebel
Copy link
Contributor Author

Sure, i can provide the documentation

@adamretter
Copy link
Contributor

adamretter commented Oct 26, 2018

@mathias-goebel LGTM. You should probably also submit them to the YAJSW project.

@adamretter
Copy link
Contributor

@mathias-goebel would you also be able to submit PR's for the develop-4.x.x and develop-5.0.0 branches too?

@duncdrum duncdrum removed the needs documentation Signals issues or PRs that will require an update to the documentation repo label Dec 4, 2018
@duncdrum
Copy link
Contributor

duncdrum commented Dec 4, 2018

docs added see eXist-db/documentation#276

@mathias-goebel
Copy link
Contributor Author

@mathias-goebel would you also be able to submit PR's for the develop-4.x.x and develop-5.0.0 branches too?

I am not sure how to create a merge request for two targets.

@duncdrum
Copy link
Contributor

@mathias-goebel you checkout the dev-4 branch, create a feat-4 branch of that one, git cherry-pick your changes (by commit id), push, and open a pr from your feat-4 branch against dev-4.

rinse and repeat for dev-5.

@adamretter adamretter changed the title unattended installation (closes eXist-db/exist#2239) Unattended Installation Jan 21, 2019
@adamretter adamretter merged commit df0bdb1 into eXist-db:develop Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement new features, suggestions, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants