Skip to content

[refactor] Improve XQsuite code..#6035

Open
dizzzz wants to merge 4 commits intoeXist-db:developfrom
dizzzz:improvements/xqsuite
Open

[refactor] Improve XQsuite code..#6035
dizzzz wants to merge 4 commits intoeXist-db:developfrom
dizzzz:improvements/xqsuite

Conversation

@dizzzz
Copy link
Member

@dizzzz dizzzz commented Feb 6, 2026

Insignificant improvements of XQsuite test code.

@dizzzz dizzzz requested review from duncdrum and line-o February 6, 2026 20:07
@dizzzz dizzzz requested a review from a team as a code owner February 6, 2026 20:07
@dizzzz dizzzz force-pushed the improvements/xqsuite branch from 51ce716 to 495ee02 Compare February 6, 2026 20:09
Copy link
Member

@line-o line-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes are fine. @duncdrum did also work on the same classes so I hope we can bring both your work together and will offer my help in achieving this.

@duncdrum
Copy link
Contributor

duncdrum commented Feb 7, 2026

@dizzzz beat me to it, see #6036

@dizzzz
Copy link
Member Author

dizzzz commented Feb 7, 2026

Oops. My code is mostly mechanically generated . Can redo that easily. Except one java9 thing

@dizzzz dizzzz mentioned this pull request Feb 9, 2026
@dizzzz dizzzz force-pushed the improvements/xqsuite branch from 0e965c4 to 721b745 Compare February 10, 2026 19:45
Comment on lines +53 to +54
} catch (final ClassNotFoundException | InstantiationException | IllegalAccessException |
InvocationTargetException | NoSuchMethodException e) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One could use the parent ReflectiveOperationException instead those existing ones

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants