Conversation
PYTHONPATH in the created module file. This happens independent of an installed EB software, so it even happens if the software was installed before and you recreate the modulefile.
|
Automatic reply from Jenkins: Can I test this? |
There was a problem hiding this comment.
please use the adjust_permissions function available from easybuild.tools.filetools for this, something like:
adjust_permissions('configure', stat.S_IXUSR, add=True)
and only import additional stuff at the top of the easyblock, where the other imports are; you'll need to add:
import stat
...
from easybuild.tools.filetools import adjust_permissions
|
Jenkins: ok to test |
|
Easyblocks unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1375/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Easyblocks unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1376/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
@blappm: please ignore the failing tests, something is broken in |
|
Jenkins: test this please |
|
Easyblocks unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1386/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
Jenkins: ok to test |
|
Easyblocks unit test suite PASSed (see https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1391/console for more details). This pull request is now ready for review/testing. Please try and find someone who can tackle this; contact @boegel if you're not sure what to do. |
|
Good to go, thanks @blappm! Congratulations on your first contribution to EasyBuild, keep them coming! |
There was a problem hiding this comment.
this needs a check like:
if os.path.exists('configure'):it's possible that the configure script is not present yet, and gets generated 'on-the-fly' by using
preconfigopts = './autogen.sh && '
| self.cfg.update('preconfigopts', "%s='%s'" % (key, val)) | ||
|
|
||
| # Ensure that configure has the excutable bit set, needed if a patch created configure itself | ||
| if os.path.exists('configure'): |
There was a problem hiding this comment.
wrong indentation (one or two leading spaces too much):
Failed to obtain class for ConfigureMake easyblock (not available?): unindent does not match any outer indentation level (configuremake.py, line 86)
|
Easyblocks unit test suite FAILed. See https://jenkins1.ugent.be/job/easybuild-easyblocks-pr-builder/1392/console for more details. Please fix the reported issues by pushing additional commits to the branch corresponding with this pull request; contact @boegel if you're not sure what to do. |
|
@blappm: reping :) |
|
@blappm: another ping? This needs a sync with |
3 participants
Chmod a configure file to make it always executable