Skip to content

Do a Chmod for configure #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blappm wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Do a Chmod for configure #749

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
94b6302
eb --module-only skips the PYTHONPATH define, resulting in a corrupt
Nov 25, 2015
4cf3097
Change tab to spaces
Nov 25, 2015
68a5398
Chmod a configure file to make it always executable.
blappm Nov 25, 2015
fa709d0
Revert changes from former pull request
Nov 25, 2015
96fd1f5
Use adjust_permissions() instead of os.chmod()
Nov 25, 2015
ccdba02
Check if configure exists
blappm Nov 26, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions easybuild/easyblocks/generic/configuremake.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@ def configure_step(self, cmd_prefix=''):
for (key, val) in tar_vars.items():
self.cfg.update('preconfigopts', "%s='%s'" % (key, val))

# Ensure that configure has the excutable bit set, needed if a patch created configure itself
import os
os.chmod('./configure', 0755)
Copy link
Member

@boegel boegel Nov 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the adjust_permissions function available from easybuild.tools.filetools for this, something like:

adjust_permissions('configure', stat.S_IXUSR, add=True)

and only import additional stuff at the top of the easyblock, where the other imports are; you'll need to add:

import stat
...
from easybuild.tools.filetools import adjust_permissions

cmd = "%(preconfigopts)s %(cmd_prefix)s./configure %(prefix_opt)s%(installdir)s %(configopts)s" % {
'preconfigopts': self.cfg['preconfigopts'],
'cmd_prefix': cmd_prefix,
Expand Down