Fix/reference cycle guard signed #455
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
referredSemanticIdchains inDefaultReferenceby rejecting self/indirect cycles during assignmentBackground
Jackson XML serialization blew up with a StackOverflow when
Reference.referredSemanticIdcontained a cycle (e.g.,Reference -> Reference -> same Reference). The model allowed such graphs because the setter did not guard against cycles. This PR keeps the model acyclic so downstream serializers do not need custom circular-reference handling. This removes the root cause behind SAMM CLI’s infinite recursion during AAS generation (see esmf-sdk#802).Implementation Notes
referredSemanticIdchain once and fails fast with a clearIllegalArgumentExceptionmessageTesting
mvn -pl model test -Dmaven.repo.local=./.m2