-
Notifications
You must be signed in to change notification settings - Fork 51
Add device reset #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add device reset #365
Conversation
Signed-off-by: Thorsten de Buhr <[email protected]>
Signed-off-by: Thorsten de Buhr <[email protected]>
|
The functionality in the PR is complete. Still trying to make the automated tests work on our end before adding some for this PR. |
jreineckearm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, changes look good to me! And work nicely in combination with eclipse-cdt-cloud/cdt-gdb-vscode#152 .
Makes sense to only support for gdbtarget type while having parts of the implementation in the base classes for both.
It would in theory also work for gdb type. But I don't see the use case.
Button in GUI is correctly hidden if not using customResetCommands.
Good to merge as far as I am concerned. Merging only tomorrow (CET) though to give others the chance to review (CC: @asimgunes , @jonahgraham )
jonahgraham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the new code be de-duplicated? customResetCommands was added to GDBDebugSession but customResetRequest was added to GDBTargetDebugSession. That means customResetCommands is effectively unreferenced in GDBDebugSession.
Can you move all of it to GDBDebugSessionBase?
- [Add device reset](eclipse-cdt-cloud/cdt-gdb-adapter#365) - [Suppressing unneeded error message when hovering](eclipse-cdt-cloud/cdt-gdb-adapter#366)
- [Add device reset](eclipse-cdt-cloud/cdt-gdb-adapter#365) - [Suppressing unneeded error message when hovering](eclipse-cdt-cloud/cdt-gdb-adapter#366) Co-authored-by: Jens Reinecke <[email protected]>
* Add Device Reset Signed-off-by: Thorsten de Buhr <[email protected]> --------- Signed-off-by: Thorsten de Buhr <[email protected]>
Adds:
Custom Reset (configured via launch.json).
Issue: #359
Testing:
Required: eclipse-cdt-cloud/cdt-gdb-vscode#152
In a target project, launch.json, add this. The command uses pyOCD but can be any other.
Note:
The GUI update depends on an asynchronous event from GDB (such as Target STOPPED), likely triggered by the connected target debugger. If this event is absent (e.g. in current pyOCD), test it by performing a single step-into after pressing the Custom Reset button.