-
Notifications
You must be signed in to change notification settings - Fork 28
Add device reset #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add device reset #152
Conversation
In launch.json: "customResetCommands": [] Signed-off-by: Thorsten de Buhr <[email protected]>
Signed-off-by: Thorsten de Buhr <[email protected]>
|
We do have some lightweight documentation in the README.md. Could you please add the new setting there, too? |
Signed-off-by: Thorsten de Buhr <[email protected]>
jreineckearm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM and work nicely with eclipse-cdt-cloud/cdt-gdb-adapter#365 . The other PR against the adapter needs to be merged and released first though.
Approved but merging only tomorrow (CET) to give others time to review, too. (CC: @jonahgraham , @asimgunes).
jonahgraham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the changelog comment I approve of this.
Signed-off-by: Thorsten de Buhr <[email protected]>
Signed-off-by: Thorsten de Buhr <[email protected]>
Signed-off-by: Thorsten de Buhr <[email protected]>
jreineckearm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog looks good now, thanks for spotting this, @jonahgraham ! I agree that we should restrict issue links in the changelog to Eclipse CDT Cloud repo issues.
|
Waiting with merge until complementary adapter change is merged and released. |
Adds:
Custom Reset (configured via launch.json).
Issue: eclipse-cdt-cloud/cdt-gdb-adapter#359
Testing:
Required: eclipse-cdt-cloud/cdt-gdb-adapter#365
In a target project, launch.json, add this. The command uses pyOCD but can be any other.
Note:
The GUI update depends on an asynchronous event from GDB (such as Target STOPPED), likely triggered by the connected target debugger. If this event is absent (e.g. in current pyOCD), test it by performing a single step-into after pressing the Custom Reset button.