Skip to content

Conversation

@thorstendb-ARM
Copy link
Contributor

@thorstendb-ARM thorstendb-ARM commented May 12, 2025

Adds:

Custom Reset (configured via launch.json).
Issue: eclipse-cdt-cloud/cdt-gdb-adapter#359

Testing:

Required: eclipse-cdt-cloud/cdt-gdb-adapter#365
In a target project, launch.json, add this. The command uses pyOCD but can be any other.

    "configurations": [
        {
            "name": "pyOCD cdt-gdb-adapter",
            ...
            "customResetCommands": [
                "monitor reset halt hardware",
            ],
        },

Note:

The GUI update depends on an asynchronous event from GDB (such as Target STOPPED), likely triggered by the connected target debugger. If this event is absent (e.g. in current pyOCD), test it by performing a single step-into after pressing the Custom Reset button.

In launch.json: "customResetCommands": []

Signed-off-by: Thorsten de Buhr <[email protected]>
@jreineckearm
Copy link
Contributor

We do have some lightweight documentation in the README.md. Could you please add the new setting there, too?

@jreineckearm jreineckearm requested a review from jonahgraham May 12, 2025 07:11
Copy link
Contributor

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM and work nicely with eclipse-cdt-cloud/cdt-gdb-adapter#365 . The other PR against the adapter needs to be merged and released first though.

Approved but merging only tomorrow (CET) to give others time to review, too. (CC: @jonahgraham , @asimgunes).

Copy link
Contributor

@jonahgraham jonahgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the changelog comment I approve of this.

Signed-off-by: Thorsten de Buhr <[email protected]>
Signed-off-by: Thorsten de Buhr <[email protected]>
Signed-off-by: Thorsten de Buhr <[email protected]>
Copy link
Contributor

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog looks good now, thanks for spotting this, @jonahgraham ! I agree that we should restrict issue links in the changelog to Eclipse CDT Cloud repo issues.

@jreineckearm
Copy link
Contributor

Waiting with merge until complementary adapter change is merged and released.

@jreineckearm jreineckearm merged commit d97c325 into eclipse-cdt-cloud:main May 22, 2025
5 checks passed
@thorstendb-ARM thorstendb-ARM deleted the addDeviceReset branch May 27, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants