Suppressing unneeded error message when hovering#366
Suppressing unneeded error message when hovering#366jreineckearm merged 16 commits intoeclipse-cdt-cloud:mainfrom
Conversation
|
Addresses #363 |
jreineckearm
left a comment
jreineckearm
left a comment
There was a problem hiding this comment.
Changes LGTM!
@jonahgraham , @asimgunes , do you have any concerns with this? Planning to merge otherwise tomorrow night (CET) or on Wednesday.
|
@omarArm , automated tests failed. Please have a look. Be aware though that running them on macOS isn't straight forward. Still working with @thorstendb-ARM to get them going. |
jreineckearm
left a comment
jreineckearm
left a comment
There was a problem hiding this comment.
Revoking approval due to failing tests.
|
Hi, the tests are failing because my changes are changing the expected behaviour when a failing evaluate request is being triggered. That is by design on my side, I think the test script itself should change |
jonahgraham
left a comment
jonahgraham
left a comment
There was a problem hiding this comment.
It looks like multiple topics are included in this PR. I added a comment on the part that I can identify as applicable to the PR description and related issue. All the other stuff about breakpoints seem to be a different topic.
running yarn format
editing evaluate request test
updationg test title
removed error message from hovering box
jreineckearm
left a comment
jreineckearm
left a comment
There was a problem hiding this comment.
Thanks for the updates. LGTM!
Let's make sure to squash and merge this PR and clean up the commit message for that.
Will leave this PR unmerged until tomorrow (CET) to give others a chance to review because the changes are user visible (CC: @jonahgraham , @asimgunes ).
- [Add device reset](eclipse-cdt-cloud/cdt-gdb-adapter#365) - [Suppressing unneeded error message when hovering](eclipse-cdt-cloud/cdt-gdb-adapter#366)
- [Add device reset](eclipse-cdt-cloud/cdt-gdb-adapter#365) - [Suppressing unneeded error message when hovering](eclipse-cdt-cloud/cdt-gdb-adapter#366) Co-authored-by: Jens Reinecke <jens.reinecke@arm.com>
3 participants
Previous behaviour:
when hovering over non variables, i.e. comments or keywords (for, while, etc.), an error message appeared "-var-create: unable to create variable object". Although this is technically a correct behaviour, it was frustrating to users to see an error message just because they are hovering over comment sections in their code.
Current behaviour:
This error message is now suppressed when hovering over comments.