-
Notifications
You must be signed in to change notification settings - Fork 51
Preventing "Commands" Command and cleanup #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreineckearm
merged 11 commits into
eclipse-cdt-cloud:main
from
omarArm:coverCommandsCommand
Dec 8, 2025
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
1ef25ff
Adding a warning to users when they try the commands command via the …
omarArm 4c4e0a0
failing silently when commands command is sent
omarArm 756ebd2
updating warning message to show the real cause of the issue
omarArm a409379
removing the double quotes from the warning message
omarArm 3586412
removing the double quotes from the test name
omarArm 211eb58
changing tests infrastructure to have chai globally
omarArm ff6dc49
making regex more robust against args and short forms
omarArm 36fdce8
ran a yarn format
omarArm 595e4d9
update test to match change in warning message
omarArm 991f2f5
removing binary file that was added by mistake
omarArm f87833a
adding copyright message and update mocharc for windows
omarArm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| { | ||
| "//": "This timeout should match what is in CdtDebugClient constructor", | ||
| "timeout": "25000" | ||
| "timeout": "25000", | ||
| "require": ["ts-node/register", "src/integration-tests/test/setup.ts"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| { | ||
| "//": "This timeout should match what is in CdtDebugClient constructor", | ||
| "timeout": "5000" | ||
| "timeout": "5000", | ||
| "require": ["ts-node/register", "src/integration-tests/test/setup.ts"] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| /********************************************************************* | ||
| * Copyright (c) 2025 Arm Limited and others | ||
| * | ||
| * This program and the accompanying materials are made | ||
| * available under the terms of the Eclipse Public License 2.0 | ||
| * which is available at https://www.eclipse.org/legal/epl-2.0/ | ||
| * | ||
| * SPDX-License-Identifier: EPL-2.0 | ||
| *********************************************************************/ | ||
|
|
||
| import * as chai from 'chai'; | ||
omarArm marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| import * as chaiString from 'chai-string'; | ||
|
|
||
| chai.use(chaiString); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.