Adding a custom event to trigger re-rendering of breakpoints in source code #153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quest toggling all breakpoints
Contributor
|
While testing this on Windows, I noticed that the event handling for refreshing the breakpoint GUI does not work if the breakpoint added through the debug console is the first breakpoint added to an empty list. Before merge, we at least need to understand why this happens. |
Contributor
|
Turns out this was an issue in the adapter side of the feature. Fixed with latest commits. |
jreineckearm
approved these changes
May 26, 2025
Contributor
jreineckearm
left a comment
jreineckearm
left a comment
There was a problem hiding this comment.
Changes look good to me and can be merged after eclipse-cdt-cloud/cdt-gdb-adapter#368 is available to be picked up in a cdt-gdb-adapter NPM release.
Contributor
|
Merging, one last test when pulling adapter v1.0.9 before next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I added a custom event for triggering a re-render of breakpoints in source code, because just sending a breakpoint event from the adapter to the extension was not enough
Please see
eclipse-cdt-cloud/cdt-gdb-adapter#368