extension: Start trace server before opening trace #142
Conversation
|
Comment from internal, from @bhufmann:
|
Start the trace server if known as stopped, and if [1] is installed, before opening traces. [1] https://github.com/eclipse-cdt-cloud/vscode-trace-server Contributes to fixing Issue #15. Signed-off-by: Marco Miller <[email protected]>
bhufmann
left a comment
bhufmann
left a comment
There was a problem hiding this comment.
I think this is also a question to the community if that is a general behaviour that is expected. In our use case it's a yes, but I know from the theia-trace-extension adopters, that they have other means to start the server for the end-user and there is an additional open command that doesn't try to start the server.
There was a problem hiding this comment.
Besides, with the current implementation, it requires the vscode-traceserver to be installed to have the commands available. This adds a tight coupling to vscode-traceserver. What about an api in vscode-trace-extension that other extensions can register a start and stop callback. This will allow other implementations that vscode-traceserver. Just a thought.
|
hi, it seems that this feature has been backlogged. Is there any plan to add an api for other extensions to register start and stop callback? I'd like to build upon #149 for this feature. Please let me know your thoughts, thanks |
|
This one can be closed due to #155. Thanks for the proposal. |
3 participants
Start the trace server if known as stopped, and if [1] is installed, before opening traces.
[1] https://github.com/eclipse-cdt-cloud/vscode-trace-server
Contributes to fixing Issue #15.
Signed-off-by: Marco Miller [email protected]