Automatic start trace server when user requests to open a trace #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Replaces #142 which this one is inspired by. |
bhufmann
force-pushed
the
auto-start
branch
3 times, most recently
from
bff05a8 to
9197eea
Compare
colin-grant-work
left a comment
colin-grant-work
left a comment
There was a problem hiding this comment.
The code looks pretty good to me. Perhaps @hriday-panchasara could give it a quick functional test to catch any subtleties I've missed.
hriday-panchasara
approved these changes
Jun 28, 2023
Contributor
hriday-panchasara
left a comment
hriday-panchasara
left a comment
There was a problem hiding this comment.
Works as expected, thanks for the contribution.
This change uses the vscode-trace-server commands to start a trace server and when the server is started it will perform the pending open command. This change relies on the vscode-trace-server extension. In a future release an API can be introduced so that an extension can register the start/stop commands and also the started notification. This future enhancement would decouple the vscode-trace-extension with the vscode-trace-server implementation. Contributes to fixing Issue eclipse-cdt-cloud#15 Signed-off-by: Bernd Hufmann <[email protected]>
Contributor
Author
|
I'll open an new issue tracker for introducing an external API so that an extension can register the start/stop commands and also the started notification. This future enhancement would decouple the vscode-trace-extension with the vscode-trace-server implementation. See also #149 about the external API discussions. |
This was referenced Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses the vscode-trace-server commands to start a trace server and when the server is started it will perform the pending open command.
This change relies on the vscode-trace-server extension.
In a future release an API can be introduced so that an extension can register the start/stop commands and also the started notification. This future enhancement would decouple the vscode-trace-extension with the vscode-trace-server implementation.
Fixes #15
Signed-off-by: Bernd Hufmann [email protected]