Skip to content

Conversation

@haydar-metin
Copy link
Contributor

@haydar-metin haydar-metin commented Feb 27, 2025

Provides an initial structure for the repository:

Project

Used Tools:

  • ESLint v9
  • Prettier
  • TSC

Components:

  • Tree
  • Tooltip

Structure:

src/  
│── base/           # Shared functionality  
│── vscode/         # VSCode specific functionality  

├── <component>/  
│   ├── browser/    # React specific code  
│   ├── common/     # Shared code between browser and VSCode  
│   ├── vscode/     # VSCode integration (converters, webview providers, etc.)  

├── <component>/  
│   ├── *.ts(x)       # React Components without VSCode integration  

The components are extracted from https://github.com/eclipse-cdt-cloud/vscode-peripheral-inspector

How to test

See eclipse-cdt-cloud/vscode-peripheral-inspector#51

Copy link
Contributor

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @haydar-metin !
Haven't tested yet. Will give it a try with the Peripheral Inspector branch.
Also need to have another look at how the parts play together to fully understand the code.

Just to confirm: this is for the start only the tree-table, right? It does not include the simpler tree variant with inline editing/controls.

We may want to set something up around TPIP tracking. But I believe this is something that also affects other repos.

@haydar-metin
Copy link
Contributor Author

Just to confirm: this is for the start only the tree-table, right? It does not include the simpler tree variant with inline editing/controls.

Yes, I only moved the components from the other repository. Therefore, there are no changes. I will update the components again after the open PR with editing capabilities has been merged.

Copy link
Contributor

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more review comments. It would be great to give developers more guidance on how to reuse existing TreeDataProviders in the README.md.

Tested locally with suggested peripheral inspector PR. What I tested worked nicely. :-)

Overall, this looks great. Happy to approve after feedback has been addressed.
Awesome work on this!

@haydar-metin
Copy link
Contributor Author

haydar-metin commented Mar 18, 2025

@jreineckearm Thanks for the feedback! Please see 31746ed for the changes. Publishing to NPM will be done in a separate PR.

Copy link
Contributor

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks, @haydar-metin , for incorporating this feedback!

Just a few minor comments/questions. But I think we can merge after addressing/answering those.
Let's bring in pending changes from open Peripheral Inspector changes as they come.
Also, let's look at TPIP docs separately as mentioned in the comment.

Copy link
Contributor

@jreineckearm jreineckearm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! Good to merge.

@jreineckearm jreineckearm merged commit 341544c into eclipse-cdt-cloud:main Mar 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants